Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCP Persistent Volumes export failing due to duplicated metrics #143

Closed
Pokom opened this issue Apr 2, 2024 · 0 comments · Fixed by #144
Closed

GCP Persistent Volumes export failing due to duplicated metrics #143

Pokom opened this issue Apr 2, 2024 · 0 comments · Fixed by #144
Assignees
@Pokom
Labels
area/capacity

Comments

@Pokom
Copy link
Contributor

Pokom commented Apr 2, 2024

#142 introduced a regression where there's potential for multiple disks to have the same volume name. The only scenario I've encountered where this would happen:

  1. Velero PVC backup restores
Pokom added a commit that referenced this issue Apr 2, 2024
@Pokom
fix(google): Deduplicate disks to export
42ae4e3 
Introduce a simple map to keep track of seen disks to ensure we do not
emit metrics for disks already seen.

- closes #143
@Pokom Pokom mentioned this issue Apr 2, 2024
Merged
@Pokom Pokom self-assigned this Apr 2, 2024
@Pokom Pokom assigned logyball and Pokom and unassigned Pokom and logyball Apr 2, 2024
@Pokom Pokom closed this as completed in #144 Apr 2, 2024
Pokom added a commit that referenced this issue Apr 2, 2024
@Pokom
fix(google): Deduplicate disks to export (#144)
7c3eb4e 
Introduce a simple map to keep track of seen disks to ensure we do not emit metrics for disks already seen.

- closes #143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pokom Pokom

Labels
area/capacity
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(google): Deduplicate disks to export grafana/cloudcost-exporter
2 participants
@Pokom @logyball