-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documenation on Beyla's performance #1573
Conversation
docs/sources/performance.md
Outdated
|
||
## Further reading | ||
|
||
* [Beyla performance calculation](https://docs.google.com/document/d/e/2PACX-1vTNbMqlkLRM0FtUdEqyderTePEjcK-s6FgDhKyzujWnhuS6ty9Ut4S-c3mgQcHt72el0BG3Iy5jV_AK/pub). This document contains the raw data and graphs of the performance tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried with my personal google account and couldn't access. Seems that this document is not visible for non-grafana accounts.
I'm afraid that this link becomes accidentally broken at some point. Is there any gdoc --> markdown exporter so we can keep it in a folder in our docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I replaced by a pdf instead. Would this work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would work as long as @grafsean is fine with it
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1573 +/- ##
==========================================
+ Coverage 68.44% 71.07% +2.63%
==========================================
Files 196 197 +1
Lines 19628 19792 +164
==========================================
+ Hits 13434 14068 +634
+ Misses 5499 5049 -450
+ Partials 695 675 -20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marctc nice! Could you review my copy edits.
LGTM! |
Add documentation around performance impact of using Beyla.
Fixes #1405