-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix name generation for BPF metrics #1552
base: main
Are you sure you want to change the base?
Conversation
marctc
commented
Jan 21, 2025
- Fixed how names are fetched, making possible to get the full name!
- Bump cillium to 0.17
- Simplified logic of metrics collection
- Fetch only probes that are Kprobes (this includes all Beyla probes)
- Fetch only maps that are LRUHash (this includes all Beyla maps)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1552 +/- ##
===========================================
- Coverage 67.74% 34.66% -33.08%
===========================================
Files 197 193 -4
Lines 19755 19598 -157
===========================================
- Hits 13383 6794 -6589
- Misses 5685 12214 +6529
+ Partials 687 590 -97
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The way you encapsulated the name fetching is really elegant. I've added a few suggestions, which are mere ... suggestions (and very personal taste, so feel free to ignore).
Co-authored-by: Rafael Roquetto <[email protected]>
Co-authored-by: Rafael Roquetto <[email protected]>
Co-authored-by: Rafael Roquetto <[email protected]>
Co-authored-by: Rafael Roquetto <[email protected]>
Looking closer at the ebpf code, it turns out this may require
I don't see a simple way out (without BTF and without renaming the probes) apart from generating a go map matching the 16 first chars as a key and the full probe name as a value. I hacked a quick script that does it just a a POC, so we could maybe do something similar in go and invoke with Here's the script (place it inside the And the proposed (generated) output: |