Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y: Add a11y lint plugin #199

Merged
merged 3 commits into from
Jan 6, 2023
Merged

A11y: Add a11y lint plugin #199

merged 3 commits into from
Jan 6, 2023

Conversation

idastambuk
Copy link
Contributor

More info in/implements #29

@idastambuk idastambuk requested a review from a team as a code owner December 29, 2022 18:37
@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2022

Levitate is-compatible report:

🔍 Resolving @grafana/data@latest...
🔍 Resolving @grafana/ui@latest...
🔍 Resolving @grafana/runtime@latest...
🔍 Resolving @grafana/e2e-selectors@latest...

🔬 Checking compatibility between ./src/module.ts and @grafana/[email protected]...
✔ Found @grafana/data version 9.3.2 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/[email protected]...
✔ Found @grafana/ui version 9.3.2 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/[email protected]...
✔ Found @grafana/runtime version 9.3.2 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/[email protected]...
✔ Found @grafana/e2e-selectors version 9.3.2 locally

✔️ ./src/module.ts appears to be compatible with @grafana/data,@grafana/ui,@grafana/runtime,@grafana/e2e-selectors

@github-actions
Copy link
Contributor

Backend code coverage report for PR #199
No changes

@github-actions
Copy link
Contributor

Frontend code coverage report for PR #199
No changes

@idastambuk idastambuk mentioned this pull request Dec 29, 2022
Copy link
Contributor

@sunker sunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! No issues in this project, or will the linter only highlight problems in changed files?

Copy link
Contributor

@kevinwcyu kevinwcyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 nice!

Copy link
Member

@sarahzinger sarahzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay! Tested it by adding a lint error! Works for me!
Screenshot 2023-01-04 at 3 34 35 PM

@idastambuk
Copy link
Contributor Author

Nice! No issues in this project, or will the linter only highlight problems in changed files?

It runs the check in all files it seems, so should be fine project-wise if it passes.

@idastambuk idastambuk merged commit f32658b into main Jan 6, 2023
@idastambuk idastambuk deleted the chore/a11y-lint branch January 6, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants