Add live graph backend (merge to feature branch) #2645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thampiotr
reviewed
Feb 11, 2025
internal/component/otelcol/internal/lazyconsumer/lazyconsumer.go
Outdated
Show resolved
Hide resolved
internal/component/otelcol/internal/lazyconsumer/lazyconsumer_test.go
Outdated
Show resolved
Hide resolved
internal/component/otelcol/internal/livedebuggingconsumer/livedebuggingconsumer.go
Outdated
Show resolved
Hide resolved
internal/component/otelcol/internal/livedebuggingconsumer/livedebuggingconsumer.go
Outdated
Show resolved
Hide resolved
wildum
force-pushed
the
live-graph-backend
branch
from
a79c730 to
0dd571d
Compare
thampiotr
reviewed
Feb 12, 2025
internal/component/otelcol/internal/livedebuggingconsumer/livedebuggingconsumer.go
Outdated
Show resolved
Hide resolved
thampiotr
reviewed
Feb 12, 2025
internal/component/otelcol/internal/livedebuggingconsumer/livedebuggingconsumer.go
Outdated
Show resolved
Hide resolved
thampiotr
reviewed
Feb 12, 2025
thampiotr
reviewed
Feb 17, 2025
internal/component/otelcol/internal/interceptorconsumer/logs.go
Outdated
Show resolved
Hide resolved
internal/component/otelcol/internal/interceptorconsumer/logs.go
Outdated
Show resolved
Hide resolved
internal/component/otelcol/internal/interceptorconsumer/logs.go
Outdated
Show resolved
Hide resolved
internal/component/otelcol/internal/livedebuggingpublisher/livedebuggingpublisher.go
Outdated
Show resolved
Hide resolved
| return ids | ||
| } | ||
|
|
||
| func PublishLogsIfActive(debugDataPublisher livedebugging.DebugDataPublisher, componentID string, ld plog.Logs, nextLogs []otelcol.Consumer) { |
There was a problem hiding this comment.
I don't think nextLogs needs to be otelcol.Consumer, you only ever use them to extract component ID.
There was a problem hiding this comment.
True but it's quite handy for the components because it's easy to provide.
Would you prefer that I change it to:
PublishLogsIfActive(debugDataPublisher livedebugging.DebugDataPublisher, componentID string, ld plog.Logs, componentIDs []string)
and that I export the extractIDs function?
Or do you have a different idea in mind? I'd like to keep the code as little intrusive as possible in the components
There was a problem hiding this comment.
I was thinking to use a smaller interface, like
type NamedComponent interface {
ComponentID() string
}
cause that's all you need
There was a problem hiding this comment.
does that work for you: 7392390 ?
thampiotr
approved these changes
Feb 24, 2025
| return ids | ||
| } | ||
|
|
||
| func PublishLogsIfActive(debugDataPublisher livedebugging.DebugDataPublisher, componentID string, ld plog.Logs, nextLogs []otelcol.Consumer) { |
There was a problem hiding this comment.
I was thinking to use a smaller interface, like
type NamedComponent interface {
ComponentID() string
}
cause that's all you need
wildum
added a commit
that referenced
this pull request
Feb 28, 2025
* add live graph backend * update discovery process * review feedback1 * review feedback 2 * change back to splitting functions in livedebugging service * fix race condition in otel receiver * add comment about memory leak * rework live debugging for otel components * add comment about window unit * review feedback * fix tests * use interface in publish live debugging data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This is the backend part of the new live graph.
The approach is similar to live debugging, except that it adds the callback to all components in the given module.
The live debugging feed is now a struct that contains data needed to build the new graph. Because the data string is not needed for the graph, it's passed around as a function. This way we can use the same struct for the live debugging and the live graph with limited performance overhead.
Which issue(s) this PR fixes
Fixes #2608
Notes to the Reviewer
This was tested manually via curl:
curl -N http://localhost:12345/api/v0/web/graphto get the data from all components at the rootcurl -N http://localhost:12345/api/v0/web/graph/{moduleID}to get data from a particular modulePR Checklist