Handle settings.gradle.kts or missing settings.gradle.dcl
#4
Conversation
h0tk3y
force-pushed
the
sigushkin/settings-gradle-kts-or-none
branch
from
00a3bf7 to
984be52
Compare
| List<File> candidateFiles = Stream.of("settings.gradle.dcl", "settings.gradle.kts") | ||
| .map(it -> new File(getRootDir(), "settings.gradle.dcl")) | ||
| .collect(Collectors.toList()); | ||
| return candidateFiles.stream() | ||
| .filter(File::exists) | ||
| .findFirst() | ||
| .orElse(candidateFiles.get(0)); |
There was a problem hiding this comment.
❌ Why collect it meanwhile you are streaming it again? I think this works, and it's much more readable.
| List<File> candidateFiles = Stream.of("settings.gradle.dcl", "settings.gradle.kts") | |
| .map(it -> new File(getRootDir(), "settings.gradle.dcl")) | |
| .collect(Collectors.toList()); | |
| return candidateFiles.stream() | |
| .filter(File::exists) | |
| .findFirst() | |
| .orElse(candidateFiles.get(0)); | |
| List<File> candidateFiles = Stream.of("settings.gradle.dcl", "settings.gradle.kts") | |
| .map(it -> new File(getRootDir(), "settings.gradle.dcl")) | |
| .filter(File::exists) | |
| .findFirst() | |
| .orElse(candidateFiles.get(0)); |
There was a problem hiding this comment.
.orElse(candidateFiles.get(0)) is a self-reference in the initializer expression of candidateFiles, or am I not getting it right?
I wanted to avoid duplicating the call to new File(...) and avoid duplicating the name. To avoid both, I had to introduce a named variable to reference later, and that cannot be a stream, as you cannot iterate a stream twice. I'll see how to refactor it to make it more readable.
There was a problem hiding this comment.
Do you think this would be a better option?
List<String> candidateFileNames = Arrays.asList("settings.gradle.dcl", "settings.gradle.kts");
Function<String, File> asFileInRootDirectory = it -> new File(getRootDir(), it);
return candidateFileNames.stream()
.map(asFileInRootDirectory)
.filter(File::exists)
.findFirst()
.orElse(asFileInRootDirectory.apply(candidateFileNames.get(0)));There was a problem hiding this comment.
☝️ I think this is more readable
| @@ -300,7 +300,8 @@ class DeclarativeTextDocumentService : TextDocumentService { | |||
| val fileName = uri.path.substringAfterLast('/') | |||
| val fileSchema = schemaAnalysisEvaluator.evaluate(fileName, text) | |||
| val settingsSchema = schemaAnalysisEvaluator.evaluate( | |||
| declarativeResources.settingsFile.name, declarativeResources.settingsFile.readText() | |||
| declarativeResources.settingsFile.name, | |||
| declarativeResources.settingsFile.takeIf { it.canRead() }?.readText().orEmpty() | |||
There was a problem hiding this comment.
🤔 Now I realize we don't handle these cases when adding a new settings file.
There was a problem hiding this comment.
Do you mean that the editor will not react to the creation of a settings file?
There was a problem hiding this comment.
Yeah - didCreate and didOpen would fire, but we don't have any logic saying: "ah, this is a new root build/setting file for this build"
There was a problem hiding this comment.
I decided to merge this as-is, so we have a (partially, maybe) working build sooner. Let's maybe track the problem you found as an issue?
|
Please somebody should help me I have been trying to download Gradle from Gradle site I could not download it, please I need Gradle bin file,the downloading site could not be reachable |
No description provided.