Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dataframe header type to allow integer values #10678

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

abidlabs
Copy link
Member

@abidlabs abidlabs commented Feb 25, 2025

Tiny fix, but because of this issue demo/dataframe_streaming/run.py wasn't failing at startup, which in turn was causing all of our functional tests to pass spuriously.

e.g. see #10577 where all of the functional tests pass even though the tests do not run.

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Feb 25, 2025

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes detecting...

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/ad33e8835ababeaa5941d8380339add72f9be503/gradio-5.18.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@ad33e8835ababeaa5941d8380339add72f9be503#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/ad33e8835ababeaa5941d8380339add72f9be503/gradio-client-1.12.0.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/ad33e8835ababeaa5941d8380339add72f9be503/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Feb 25, 2025

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix Dataframe header type to allow integer values

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs abidlabs added the v: patch A change that requires a patch release label Feb 25, 2025
@abidlabs abidlabs enabled auto-merge (squash) February 25, 2025 23:56
@abidlabs
Copy link
Member Author

Functional tests are failing, which I'm able to repro locally. Will look into tomorrow and fix before merging this in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants