Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where styling changes were overridden when value was updated simultaneously #10597

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

abidlabs
Copy link
Member

@abidlabs abidlabs commented Feb 14, 2025

Closes: #10572

@abidlabs abidlabs changed the title Looking into https://github.com/gradio-app/gradio/issues/10572 Looking into df styling issue Feb 14, 2025
@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Feb 14, 2025

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detecting...

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/31f17f607d3f4233166a180f25949c8ef28d6092/gradio-5.16.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@31f17f607d3f4233166a180f25949c8ef28d6092#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/31f17f607d3f4233166a180f25949c8ef28d6092/gradio-client-1.12.0.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/31f17f607d3f4233166a180f25949c8ef28d6092/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Feb 14, 2025

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/dataframe patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Looking into df styling issue

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@@ -103,7 +103,8 @@
{styling}
headers={_headers}
on:change={(e) => {
value = e.detail;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem was that previously Table.svelte was emitting changes upwards but with an empty metadata key, which was overriding the styling. Now we only look at the headers and data that are passed upwards

@abidlabs abidlabs changed the title Looking into df styling issue Fix issue where styling changes were overridden when value was updated simultaneously Feb 19, 2025
@abidlabs abidlabs requested a review from hannahblair February 19, 2025 01:14
@abidlabs abidlabs marked this pull request as ready for review February 19, 2025 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gr.Dataframe style is not working on gradio 5.16.0
2 participants