Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chatbot visible prop not reacting to changes #10161

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

freddyaboulton
Copy link
Collaborator

Description

See latest comment in #9724 - the visible prop in chatbot was not reactive
Closes: #(issue)

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Testing and Formatting Your Code

  1. PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests: bash scripts/run_backend_tests.sh

  2. Please run these bash scripts to automatically format your code: bash scripts/format_backend.sh, and (if you made any changes to non-Python files) bash scripts/format_frontend.sh

@freddyaboulton freddyaboulton changed the title Fix chatbot visible prop Fix chatbot visible prop not reacting to changes Dec 9, 2024
@freddyaboulton freddyaboulton added the t: fix A change that implements a fix label Dec 9, 2024
@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Dec 9, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Storybook ready! Storybook preview
🦄 Changes detecting...

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/cd4e66dc26f877a019326910c0815fb810fd9e62/gradio-5.8.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@cd4e66dc26f877a019326910c0815fb810fd9e62#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/cd4e66dc26f877a019326910c0815fb810fd9e62/gradio-client-1.8.0.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/cd4e66dc26f877a019326910c0815fb810fd9e62/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Dec 9, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/atoms patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix chatbot visible prop not reacting to changes

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@freddyaboulton freddyaboulton added the v: patch A change that requires a patch release label Dec 9, 2024
@freddyaboulton freddyaboulton marked this pull request as ready for review December 9, 2024 20:10
Copy link
Collaborator

@hannahblair hannahblair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just tested and fixes the issue. thanks @freddyaboulton!

@freddyaboulton
Copy link
Collaborator Author

Thank you so much @hannahblair !!

@freddyaboulton freddyaboulton merged commit 3a053cc into main Dec 9, 2024
23 of 24 checks passed
@freddyaboulton freddyaboulton deleted the fix-chatbot-visibility-bug branch December 9, 2024 23:13
@infwinston
Copy link

Thank you @freddyaboulton !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: fix A change that implements a fix v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants