-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak Chatbot bubble_full_width
behaviour
#10132
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/2ab1cdd7b077cd3e616cb428b22d6a08fc03f909/gradio-5.8.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@2ab1cdd7b077cd3e616cb428b22d6a08fc03f909#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/2ab1cdd7b077cd3e616cb428b22d6a08fc03f909/gradio-client-1.8.0.tgz Use Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/2ab1cdd7b077cd3e616cb428b22d6a08fc03f909/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
Thanks for adding the demo, that's helpful. It looks like what happened is that previously, the chatbot bubbles by default took the full width of the chatbot even if the content of the bubbles was very short. We had the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks @hannahblair!
Description
Right now it doesn't seem like the chatbot
bubble_full_width
behaviour doesn't actually have any effect; see the test demo I've added. However this PR makes a slight change to the fit-content class and makes the bubble widths up to 60%, which I have guessed is the intended visual behaviour. Happy to have a discussion around this though. Maybe we should actually deprecate this parameter?Closes: #10117
before
after
tests