Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add document styles translations #117

Merged
merged 1 commit into from
Mar 3, 2023
Merged

feat: add document styles translations #117

merged 1 commit into from
Mar 3, 2023

Conversation

codeofmochi
Copy link
Contributor

@codeofmochi codeofmochi commented Mar 3, 2023 •
edited
Loading

Closes #116

For convenience, the relevant lines are:

graasp-translations/src/constants/builder.ts

Lines 37 to 41 in a9188a1

DOCUMENT_FLAVOR_ERROR: 'DOCUMENT_FLAVOR_ERROR',
DOCUMENT_FLAVOR_INFO: 'DOCUMENT_FLAVOR_INFO',
DOCUMENT_FLAVOR_NAME: 'DOCUMENT_FLAVOR_NAME',
DOCUMENT_FLAVOR_SUCCESS: 'DOCUMENT_FLAVOR_SUCCESS',
DOCUMENT_FLAVOR_WARNING: 'DOCUMENT_FLAVOR_WARNING',

graasp-translations/src/langs/de/builder.json

Lines 33 to 37 in a9188a1

"DOCUMENT_FLAVOR_ERROR": "Fehler",
"DOCUMENT_FLAVOR_INFO": "Information",
"DOCUMENT_FLAVOR_NAME": "Stil",
"DOCUMENT_FLAVOR_SUCCESS": "Erfolg",
"DOCUMENT_FLAVOR_WARNING": "Warnung",

graasp-translations/src/langs/fr/builder.json

Lines 36 to 40 in a9188a1

"DOCUMENT_FLAVOR_ERROR": "Erreur",
"DOCUMENT_FLAVOR_INFO": "Information",
"DOCUMENT_FLAVOR_NAME": "Style",
"DOCUMENT_FLAVOR_SUCCESS": "Succès",
"DOCUMENT_FLAVOR_WARNING": "Avertissement",

graasp-translations/src/langs/en/builder.json

Lines 33 to 37 in a9188a1

"DOCUMENT_FLAVOR_ERROR": "Error",
"DOCUMENT_FLAVOR_INFO": "Information",
"DOCUMENT_FLAVOR_NAME": "Style",
"DOCUMENT_FLAVOR_SUCCESS": "Success",
"DOCUMENT_FLAVOR_WARNING": "Warning",

By the way, the 3 files do not have the same number of translations (they do not have the same number of lines).

@codeofmochi codeofmochi added the feature New feature or request label Mar 3, 2023
@codeofmochi codeofmochi requested review from pyphilia and spaenleh March 3, 2023 16:09
@codeofmochi codeofmochi self-assigned this Mar 3, 2023
@codeofmochi codeofmochi linked an issue Mar 3, 2023 that may be closed by this pull request
Add document style flavors translations #116
Closed
@codeofmochi codeofmochi force-pushed the 116-document-styles branch from 5913530 to a9188a1 Compare March 3, 2023 16:10
pyphilia
pyphilia approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😮

@codeofmochi codeofmochi merged commit 5541b71 into main Mar 3, 2023
@codeofmochi codeofmochi deleted the 116-document-styles branch March 3, 2023 17:58
@github-actions github-actions bot mentioned this pull request Mar 3, 2023
Merged
@github-actions github-actions bot mentioned this pull request Nov 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyphilia pyphilia pyphilia approved these changes

@spaenleh spaenleh Awaiting requested review from spaenleh

Assignees

@codeofmochi codeofmochi

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add document style flavors translations
2 participants
@codeofmochi @pyphilia