Backport c++ compatible mangling support to 22.3

[zakkak]

Backports: oracle#4950
Closes: #432

[jerboaa]

The fix being present should also be verifiable by recently merged integration test here: Karm/mandrel-integration-tests#122 That is the existing 22.3 branch should fail prior and pass after.

[jerboaa]

In fact, the 22.3 failure here from the nightly CI is because of this missing backport: https://github.com/graalvm/mandrel/actions/runs/3270318066/jobs/5378993901#step:10:18540

[jerboaa]

This mandrel IT test failure is fixed with #444:

Error:  Failures: 
Error:    AppReproducersTest.imageioAWTTest:429->imageioAWT:546 A different set of static libraries was expected. 
Expected: [libawt.a, libawt_headless.a, libfdlibm.a, libfontmanager.a, libjava.a, libjavajpeg.a, libjvm.a, liblcms.a, liblibchelper.a, libnet.a, libnio.a, libzip.a]
Actual:   [libawt.a, libawt_headless.a, libfdlibm.a, libfontmanager.a, libjava.a, libjavajpeg.a, libjvm.a, liblcms.a, liblibchelper.a, libmanagement_ext.a, libnet.a, libnio.a, libzip.a] ==> expected: <true> but was: <false>
[INFO] 
Error:  Tests run: 18, Failures: 1, Errors: 0, Skipped: 5

[jerboaa]

There were two failing test. One looking like a network glitch, the second as mentioned in #445 (comment).

[jerboaa]

Running mandrel integration tests with this patch and #444 pass for me locally. 2 failures without those patches. LGTM.

[adinn]

This looks good to me. I applied the patch to Mandrel 22.3 spun it up and checked the results and it seems to work ok.

One question before I ack it though. Did the upstream patches apply cleanly or did you make some tweaks. If the latter then what precisely?

[zakkak]

This looks good to me. I applied the patch to Mandrel 22.3 spun it up and checked the results and it seems to work ok.

One question before I ack it though. Did the upstream patches apply cleanly or did you make some tweaks. If the latter then what precisely?

Thank you for the review @adinn !

The only conflict was in https://github.com/oracle/graal/blob/824967bfa15973848c05e4012798dc245e8f86b5/substratevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/reflect/ReflectionFeature.java#L232-L238

Due to oracle@dc932e5 not being part of 22.3

[adinn]

@zakkak ^^^

[adinn]

The only conflict was in https://github.com/oracle/graal/blob/824967bfa15973848c05e4012798dc245e8f86b5/substratevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/reflect/ReflectionFeature.java#L232-L238

Due to oracle@dc932e5 not being part of 22.3

Ok, that looks fine then!