Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Update workflow to get the matrix from json file #181

Merged
merged 1 commit into from
Dec 3, 2020
Merged

[CI] Update workflow to get the matrix from json file #181

merged 1 commit into from
Dec 3, 2020

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented Nov 23, 2020

No description provided.

@zakkak zakkak added the testing CI and testing related issues and PRs label Nov 23, 2020
@zakkak zakkak requested a review from Karm November 23, 2020 13:25
@zakkak zakkak self-assigned this Nov 23, 2020
@zakkak
Copy link
Collaborator Author

zakkak commented Nov 23, 2020

Blocked by AdoptOpenJDK/openjdk-api-v3#319

@zakkak zakkak removed the request for review from Karm November 24, 2020 11:37
@zakkak zakkak marked this pull request as ready for review November 26, 2020 11:29
@zakkak zakkak requested review from jerboaa and Karm November 26, 2020 11:29
@jerboaa
Copy link
Collaborator

jerboaa commented Nov 26, 2020

@zakkak Are those test failures expected?

@zakkak
Copy link
Collaborator Author

zakkak commented Nov 26, 2020

Nope. I forgot to add quarkus-name to the matrix :(

PS: You were faster than the email notification :D

@zakkak zakkak force-pushed the mandrel/20.3-ci branch 3 times, most recently from 108db0b to b16df9b Compare November 27, 2020 08:46
@zakkak zakkak marked this pull request as draft November 27, 2020 09:41
@zakkak zakkak force-pushed the mandrel/20.3-ci branch 4 times, most recently from 0c2d938 to 1773083 Compare November 27, 2020 11:56
@zakkak zakkak marked this pull request as ready for review November 27, 2020 13:37
@zakkak
Copy link
Collaborator Author

zakkak commented Nov 27, 2020

@jerboaa this is now finally ready for review, sorry for the early review request.

@zakkak
Copy link
Collaborator Author

zakkak commented Dec 3, 2020

@jerboaa @Karm could one of you please review this?
The failures are expected/known.

jerboaa
jerboaa approved these changes Dec 3, 2020
View reviewed changes
Copy link
Collaborator

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with me.

@zakkak zakkak merged commit 0af1d65 into graalvm:mandrel/20.3 Dec 3, 2020
@zakkak zakkak deleted the mandrel/20.3-ci branch December 3, 2020 08:43
zakkak
zakkak commented Dec 3, 2020
View reviewed changes
.github/workflows/mandrel.yml
@@ -28,26 +28,22 @@ env:
DB_USER: hibernate_orm_test
DB_PASSWORD: hibernate_orm_test
DB_NAME: hibernate_orm_test
NATIVE_TEST_MAVEN_OPTS: "-B --settings .github/mvn-settings.xml --fail-at-end -Dquarkus.native.additional-build-args=-J-ea -Dtest-postgresql -Dtest-elasticsearch -Delasticsearch.hosts='localhost:9200' -Dtest-keycloak -Dtest-amazon-services -Dtest-db2 -Dtest-mysql -Dtest-mariadb -Dmariadb.base_url='jdbc:mariadb://localhost:3308' -Dmariadb.url='jdbc:mariadb://localhost:3308/hibernate_orm_test' -Dtest-mssql -Dtest-vault -Dtest-neo4j -Dtest-kafka -Dtest-redis -Dnative-image.xmx=5g -Dnative -Dnative.surefire.skip -Dformat.skip -Dno-descriptor-tests install -DskipDocs"
Copy link
Collaborator Author

@zakkak zakkak Dec 3, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Karm @jerboaa Please note the removal of -Dquarkus.native.additional-build-args=-J-ea this means that we no longer test with assertions enabled.
Unfortunately defining this property overrides any possibly existing definitions (e.g. https://github.com/quarkusio/quarkus/blob/20e6bdb1c1abc11a1f4e90b43c429072a66bc9c4/integration-tests/vertx-http/src/main/resources/application.properties#L11) breaking some tests.

Sorry for not mentioning it earlier.

I am going to bring this up to the Quarkus team to see how we could have both :)

Zulip chat: https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/Enabling.20assertions.20for.20in.20native-image

@zakkak zakkak mentioned this pull request Dec 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerboaa jerboaa jerboaa approved these changes

@Karm Karm Awaiting requested review from Karm

Assignees

@zakkak zakkak

Labels
affects/20.3 oca-signed testing CI and testing related issues and PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zakkak @jerboaa @graalvmbot