Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraalVM master fails to build with OpenJDK 21 after GR-49610 #598

Closed
jerboaa opened this issue Oct 24, 2023 · 7 comments
Closed

GraalVM master fails to build with OpenJDK 21 after GR-49610 #598

jerboaa opened this issue Oct 24, 2023 · 7 comments
Labels

Comments

@jerboaa
Copy link
Collaborator

jerboaa commented Oct 24, 2023

Description

GraalVM master fails to build with OpenJDK 21 with the Mandrel config after oracle#7650 with:

DEBUG [build] Build native agents...
DEBUG [OperatingSystem] Execute [/disk/graal/upstream-sources/graal/mandrel-build/lib/svm/bin/native-image, --macro:native-image-agent-library] in /disk/graal/upstream-sources/mandrel-packaging with environment variables []
Error occurred during initialization of boot layer
java.lang.module.ResolutionException: Module jdk.graal.compiler does not read a module that exports jdk.vm.ci.services
Exception in thread "main" java.lang.RuntimeException: java.lang.RuntimeException: Failed, exit code: 1
    at OperatingSystem.exec(build.java:1819)
    at build.buildAgents(build.java:310)
    at build.main(build.java:253)
Caused by: java.lang.RuntimeException: Failed, exit code: 1
    at OperatingSystem.exec(build.java:1808)
    at build.buildAgents(build.java:310)
    at build.main(build.java:253)
    at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
    at java.base/java.lang.reflect.Method.invoke(Method.java:580)
    at jdk.compiler/com.sun.tools.javac.launcher.Main.execute(Main.java:484)
    at jdk.compiler/com.sun.tools.javac.launcher.Main.run(Main.java:208)
    at jdk.compiler/com.sun.tools.javac.launcher.Main.main(Main.java:135)

The corresponding OpenJDK bug is:
https://bugs.openjdk.org/browse/JDK-8318027

OpenJDK 21 would need a patch like this one in order to be able to continue to build GraalVM master with OpenJDK 21. JDK-8318027 fixes this for OpenJDK 22.

@jerboaa jerboaa added the bug Something isn't working label Oct 24, 2023
@jerboaa
Copy link
Collaborator Author

jerboaa commented Oct 24, 2023

/cc @zakkak @Karm @galderz FYI

Copy link

This issue appears to be stale because it has been open 30 days with no activity. This issue will be closed in 7 days unless Stale label is removed, a new comment is made, or not-Stale label is added.

@zakkak
Copy link
Collaborator

zakkak commented Jan 26, 2024

@jerboaa have you tried requesting comments for jerboaa/jdk21u@27ef721 from the jdk21u project reviewers?

I have toyed a bit with @adinn's idea of defining a proxy jdk.internal.vm.compiler module but haven't got anything remotely working yet (mx refuces to build my module).

@jerboaa
Copy link
Collaborator Author

jerboaa commented Jan 26, 2024

@jerboaa have you tried requesting comments for jerboaa/jdk21u@27ef721 from the jdk21u project reviewers?

No I have not. Is this something critical to have in JDK 21? I don't think it is (as of yet).

@zakkak
Copy link
Collaborator

zakkak commented Jan 26, 2024

No, I do not think it's critical either (at least for the time being).

For the users relying on an LTS JDK we can keep building Mandrel 23.1 from https://github.com/graalvm/graalvm-for-jdk21-community-backports

This is expected to leave those users without access to more recent GraalVM features and improvements that might not be accepted for a backport in GraalVM for JDK 21. In this case the users will need to wait until the Mandrel 25.1 release (September 2025) which is planned to be built on top of the LTS JDK 25. This is also aligned with the upstream OpenJDK release cadence.

@jerboaa
Copy link
Collaborator Author

jerboaa commented Jan 26, 2024

No, I do not think it's critical either (at least for the time being).

For the users relying on an LTS JDK we can keep building Mandrel 23.1 from https://github.com/graalvm/graalvm-for-jdk21-community-backports

This is expected to leave those users without access to more recent GraalVM features and improvements that might not be accepted for a backport in GraalVM for JDK 21. In this case the users will need to wait until the Mandrel 25.1 release (September 2025) which is planned to be built on top of the LTS JDK 25. This is also aligned with the upstream OpenJDK release cadence.

Yes.

@zakkak
Copy link
Collaborator

zakkak commented Mar 27, 2024

I am closing this as not planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants