Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement api,validation,state,device_mismatched: Part Ⅰ #741

Merged
merged 2 commits into from
Sep 24, 2021

Conversation

haoxli
Copy link
Contributor

@haoxli haoxli commented Sep 9, 2021

Complete *.spec.ts in src/webgpu/api/validation and src/webgpu/api/validation/encoding


Author checklist for test code/plans:

  • All outstanding work is tracked with "TODO" in a test/file description or .unimplemented() on a test.
  • New helpers, if any, are documented using /** doc comments */ and can be found via helper_index.txt.
  • (Optional, sometimes not possible.) Tests pass (or partially pass without unexpected issues) in an implementation. (Add any extra details above.)

Reviewer sign-off for test code/plans: (Note: feel free to pull in other reviewers at any time for any reason.)

  • The test path is reasonable, the description "describes the test, succinctly, but in enough detail that a reader can read only the test plans in a file or directory and evaluate the completeness of the test coverage."
  • Tests appear to cover this area completely, except for outstanding TODOs. Validation tests use control cases.
    (This is critical for coverage. Assume anything without a TODO will be forgotten about forever.)
  • Existing (or new) test helpers are used where they would reduce complexity.
  • TypeScript code is readable and understandable (is unobtrusive, has reasonable type-safety/verbosity/dynamicity).

Complete *.spec.ts in src/webgpu/api/validation and src/webgpu/api/validation/encoding
@github-actions
Copy link

github-actions bot commented Sep 9, 2021

Previews, as seen when this build job started (47bceab):
Run tests | View tsdoc

@haoxli haoxli requested a review from kainino0x September 9, 2021 09:00
Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just ~one comment; please land after addressing comment

@github-actions
Copy link

Previews, as seen when this build job started (73762b1):
Run tests | View tsdoc

@haoxli haoxli merged commit b0291fd into gpuweb:main Sep 24, 2021
sarahM0 pushed a commit to sarahM0/cts that referenced this pull request Oct 5, 2021
* Implement api,validation,state,device_mismatched: Part Ⅰ

Complete *.spec.ts in src/webgpu/api/validation and src/webgpu/api/validation/encoding

* Rmove unnecessary getDeviceMismatched* helpers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants