Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test 1 layer 2d-array textures. #4165

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Test 1 layer 2d-array textures. #4165

merged 1 commit into from
Jan 28, 2025

Conversation

greggman
Copy link
Contributor

@greggman greggman commented Jan 28, 2025 •
edited
Loading

1 layer 2d-array textures were not tested. A backend might have issues where it incorrectly uses "layers > 1" to distinguish 2d-arrays. So test.

@greggman greggman requested a review from shrekshao January 28, 2025 10:27
@greggman greggman force-pushed the texture-2d-array-1-layer branch from f720ad9 to 226a99d Compare January 28, 2025 17:18
shrekshao
shrekshao approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@shrekshao shrekshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@greggman greggman merged commit 68f6cc4 into gpuweb:main Jan 28, 2025
1 check passed
@greggman greggman deleted the texture-2d-array-1-layer branch January 28, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrekshao shrekshao shrekshao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greggman @shrekshao