Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements filtering tests for mag/min/mipmapFilters with additional float32-filterable formats. #2915

Merged
merged 7 commits into from
Sep 9, 2023

Conversation

lokokung
Copy link
Contributor

Issue: #2072


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

@lokokung lokokung requested review from kainino0x and austinEng and removed request for kainino0x August 30, 2023 01:35
@github-actions
Copy link

Previews, as seen when this build job started (a803e3d):
Run tests | View tsdoc

@lokokung
Copy link
Contributor Author

lokokung commented Sep 8, 2023

Ah, sorry it too so long to fix! Pretty much needed to rewrite all the min/magFilter tests in order to differentiate between mirror-repeat and clamp-to-edge. We can chat offline more if there's anything in the tests that is too confusing!

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Previews, as seen when this build job started (8190920):
Run tests | View tsdoc

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Previews, as seen when this build job started (1356f6e):
Run tests | View tsdoc

Copy link
Collaborator

@austinEng austinEng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you for the incredible comments and diagrams explaining the tests!

@lokokung lokokung merged commit 0126724 into gpuweb:main Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants