Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

val: device_mismatch throughout CTS #912

Closed
kainino0x opened this issue Jan 13, 2022 · 3 comments
Closed

val: device_mismatch throughout CTS #912

kainino0x opened this issue Jan 13, 2022 · 3 comments
Assignees
@Gyuyoung

Comments

@kainino0x
Copy link
Collaborator

No description provided.

haoxli added a commit to haoxli/cts that referenced this issue Mar 21, 2022
@haoxli
Implement api,validation,state,device_mismatched: Part II
2581575 
- Update DeviceHolder to provide multiple devices with same descriptor
  at once, and remove the new DevicePool of mismatched device.
- Remove selectMismatchedDeviceOrSkipTestCase function.
- Implement remaining device mismatch tests under
  validation/encoding/cmds and validation/encoding/queue.

Fixed gpuweb#912
@haoxli haoxli mentioned this issue Mar 21, 2022
Merged
7 tasks
@haoxli haoxli closed this as completed in 64f6b15 Mar 23, 2022
@haoxli haoxli mentioned this issue Mar 28, 2022
Closed
7 tasks
@haoxli haoxli mentioned this issue Apr 5, 2022
Open
7 tasks
@kainino0x
Copy link
Collaborator Author

Reopening this issue which was accidentally auto-closed by a commit (hence why it still has status "Open"). @Gyuyoung added some more of these tests recently, so they may be done now, but we still need to review and make sure.

@kainino0x kainino0x reopened this Sep 21, 2022
@Gyuyoung
Copy link
Collaborator

Let me check if there are more tests that the device_mismatch validation tests need

Gyuyoung added a commit to Gyuyoung/cts that referenced this issue Sep 22, 2022
@Gyuyoung
Add 'render_pass_and_bundle,device_mismatch' test to attachment_compa…
c835b50 
…tibility.spec.ts

This PR adds a test to ensure that render passes cannot be called with
bundles created from another device.

Issue: gpuweb#912
Gyuyoung added a commit to Gyuyoung/cts that referenced this issue Sep 22, 2022
@Gyuyoung
Add 'render_pass_and_bundle,device_mismatch' test to attachment_compa…
f0951f7 
…tibility.spec.ts

This PR adds a test to ensure that render passes cannot be called with
bundles created from another device.

Issue: gpuweb#912
@Gyuyoung Gyuyoung mentioned this issue Sep 22, 2022
Merged
7 tasks
@kainino0x kainino0x assigned Gyuyoung and unassigned haoxli Sep 22, 2022
Gyuyoung added a commit that referenced this issue Sep 23, 2022
@Gyuyoung
Add 'render_pass_and_bundle,device_mismatch' test to attachment_compa…
e84b11b 
…tibility.spec.ts (#1858)

This PR adds a test to ensure that render passes cannot be called with
bundles created from another device.

Issue: #912
@Gyuyoung Gyuyoung mentioned this issue Sep 27, 2022
Merged
7 tasks
@Gyuyoung
Copy link
Collaborator

Gyuyoung commented Sep 30, 2022 •
edited
Loading

It's likely we've handled most of device_mismatch validation. It's difficult to find new missing cases.

@Gyuyoung Gyuyoung moved this from Open (has TODO) to Complete in CTS Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gyuyoung Gyuyoung

Labels
None yet
Projects
CTS
Status: Complete
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kainino0x @Gyuyoung @haoxli