Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

val: Update validation tests to enforce per-stage and per-pipeline-layout limits on BGL creation #230

Open
3 tasks
austinEng opened this issue Jul 8, 2020 · 1 comment · Fixed by #415
Open
3 tasks

val: Update validation tests to enforce per-stage and per-pipeline-layout limits on BGL creation #230

austinEng opened this issue Jul 8, 2020 · 1 comment · Fixed by #415
Labels
bug Something isn't working

Comments

@austinEng
Copy link
Collaborator

austinEng commented Jul 8, 2020 •
edited by kainino0x
Loading

Following resolution at the F2F gpuweb/gpuweb#409 (comment), the following tests need to be updated to enforce per-stage and per-pipeline-layout limits on BGL creation:

  • webgpu:api,validation,createBindGroupLayout:max_resources_per_stage,in_bind_group_layout,*
  • webgpu:api,validation,createBindGroupLayout:number_of_dynamic_buffers_exceeds_the_maximum_value,*
  • webgpu:api,validation,createPipelineLayout:number_of_dynamic_buffers_exceeds_the_maximum_value:*
@austinEng austinEng added the bug Something isn't working label Jul 8, 2020
kainino0x added a commit to kainino0x/cts that referenced this issue Dec 18, 2020
@kainino0x
Test fixes found by Chromium automated testing
14a5aa3 
Fixes gpuweb#230 (by moving the TODO into the repo)
Fixes gpuweb#234 (by moving the TODO into the repo)
@kainino0x kainino0x mentioned this issue Dec 18, 2020
Merged
2 tasks
kainino0x added a commit to kainino0x/cts that referenced this issue Dec 18, 2020
@kainino0x
Test fixes found by Chromium automated testing
21a9a93 
And a few other WGSL updates.

Fixes gpuweb#230 (by moving the TODO into the repo)
Fixes gpuweb#234 (by moving the TODO into the repo)
kainino0x added a commit that referenced this issue Dec 18, 2020
@kainino0x
Test fixes found by Chromium automated testing (#415)
6c4d36b 
* Test fixes found by Chromium automated testing

And a few other WGSL updates.

Fixes #230 (by moving the TODO into the repo)
Fixes #234 (by moving the TODO into the repo)

* address comments

* partially update some more WGSL
@kainino0x kainino0x added this to CTS Jun 27, 2022
@kainino0x kainino0x moved this to Open in CTS Jun 27, 2022
@kainino0x kainino0x changed the title Update validation tests to enforce per-stage and per-pipeline-layout limits on BGL creation val: Update validation tests to enforce per-stage and per-pipeline-layout limits on BGL creation Jun 27, 2022
@kainino0x
Copy link
Collaborator

Reopening because we changed our process to track all items in the bug tracker even if they have TODOs in the repository.

@kainino0x kainino0x reopened this Jun 27, 2022
@lokokung lokokung mentioned this issue May 4, 2023
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
CTS
Status: Open (has TODO)
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test fixes found by Chromium automated testing kainino0x/cts
2 participants
@kainino0x @austinEng