Skip to content

Commit

Permalink
Compat: some last is multisampled skips for rgba16float and r32float (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
shrekshao authored Jan 31, 2025
1 parent 6addaa3 commit eeea35c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/webgpu/api/operation/resource_init/texture_zero.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ TODO:

import { makeTestGroup } from '../../../../common/framework/test_group.js';
import { unreachable } from '../../../../common/util/util.js';
import { kTextureFormatInfo } from '../../../format_info.js';
import { isMultisampledTextureFormat, kTextureFormatInfo } from '../../../format_info.js';

import { checkContentsByBufferCopy, checkContentsByTextureCopy } from './check_texture/by_copy.js';
import {
Expand Down Expand Up @@ -47,6 +47,10 @@ g.test('uninitialized_texture_is_zero')
t.selectDeviceOrSkipTestCase(kTextureFormatInfo[t.params.format].feature);
})
.fn(t => {
t.skipIf(
t.params.sampleCount > 1 && !isMultisampledTextureFormat(t.params.format, t.isCompatibility)
);

const usage = getRequiredTextureUsage(
t.params.format,
t.params.sampleCount,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
kDepthStencilFormats,
kDepthStencilFormatResolvedAspect,
kTextureFormatInfo,
isMultisampledTextureFormat,
} from '../../../../format_info.js';
import { MaxLimitsTestMixin } from '../../../../gpu_test.js';
import { ValidationTest } from '../../validation_test.js';
Expand Down Expand Up @@ -1156,6 +1157,7 @@ g.test('bindings_in_bundle')

t.skipIfNeedStorageTexturesByResourceTypeAndNoStorageTextures(type0, GPUShaderStage.FRAGMENT);
t.skipIfNeedStorageTexturesByResourceTypeAndNoStorageTextures(type1, GPUShaderStage.FRAGMENT);
t.skipIf(_sampleCount! > 1 && !isMultisampledTextureFormat('r32float', t.isCompatibility));

// Two bindings are attached to the same texture view.
const usage =
Expand Down

0 comments on commit eeea35c

Please sign in to comment.