Skip to content

Commit

Permalink
Fix a bug in the calculation of stack uniformity
Browse files Browse the repository at this point in the history
* The simulation incorrectly marked some continues as non-uniform
  * this leads to some ballots being marked with the special value
  * in WGSLv1, Workgroup, and Subgroup styles this would lead to fewer
    ballots being checked (so likely no change in results)
  * in Maximal though, this leads to some ballots being a wacky value
    and extra failures
  • Loading branch information
alan-baker committed Sep 8, 2023
1 parent b8f7b88 commit d7ea45d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/webgpu/shader/execution/reconvergence/util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1966,7 +1966,7 @@ ${this.functions[i]}`;
break;
}

const uniform = this.style === Style.WGSLv1 && this.isUniform(mask, subgroupSize);
const uniform = this.style !== Style.WGSLv1 || this.isUniform(mask, subgroupSize);

let n = nesting;
for (; n >= 0; n--) {
Expand Down

0 comments on commit d7ea45d

Please sign in to comment.