Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upstream improvements from bob #12

Merged
merged 6 commits into from
Dec 20, 2024
Merged

Conversation

ErikBjare
Copy link
Member

@ErikBjare ErikBjare commented Dec 20, 2024

Fixes #3

Fixes #4


Important

Refines task management by removing unnecessary files, updating symlinks, and enhancing documentation with a new TOOLS.md.

  • Task Management:
    • Removed CURRENT_TASK.md and tasks/all/no-active-task.md.
    • Updated symlink paths in tasks/active/initial-agent-setup.md and TASKS.md.
    • Modified check_task_links.py to remove handling of CURRENT_TASK.md and no-active-task.md.
  • Documentation:
    • Updated ARCHITECTURE.md to reflect changes in task management and added reference to TOOLS.md.
    • Added TOOLS.md to describe search, navigation, and collaboration tools.
    • Removed reference to CURRENT_TASK.md in README.md.
  • Misc:
    • Added PAGER=cat to Makefile to fix git grep for users with PAGER set.

This description was created by Ellipsis for 90b4865. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 2741f5c in 47 seconds

More details
  • Looked at 580 lines of code in 10 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. tasks/active/initial-agent-setup.md:1
  • Draft comment:
    The symlink should be updated to reflect the new file structure. It should point to ../initial-agent-setup.md instead of ../all/initial-agent-setup.md.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.

Workflow ID: wflow_ViPjfFyTxPIlACXv


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 6a00992 in 17 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. fork.sh:79
  • Draft comment:
    CURRENT_TASK.md is still being created in the script, which contradicts the PR description stating its removal. Consider removing the creation of CURRENT_TASK.md.
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.

Workflow ID: wflow_3VnZF2zdqQSCcgOa


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on d0af5d9 in 19 seconds

More details
  • Looked at 53 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. knowledge/forking-workspace.md:13
  • Draft comment:
    The reference to CURRENT_TASK.md should be removed as it is no longer used. This applies to other documentation files if they reference CURRENT_TASK.md.
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.

Workflow ID: wflow_i3N8gYf0y7f0agbt


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 90b4865 in 33 seconds

More details
  • Looked at 47 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. fork.sh:143
  • Draft comment:
    The removal of the symlink for CURRENT_TASK.md is consistent with the PR's goal to eliminate it. Ensure that all references to CURRENT_TASK.md are removed throughout the codebase.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The removal of CURRENT_TASK.md is consistent across the files, and the PR description indicates this was intentional. The changes in fork.sh, gptme.toml, and knowledge/forking-workspace.md reflect this removal.
2. gptme.toml:6
  • Draft comment:
    The removal of CURRENT_TASK.md from the list is consistent with the PR's goal to eliminate it. Ensure that all references to CURRENT_TASK.md are removed throughout the codebase.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The removal of CURRENT_TASK.md is consistent across the files, and the PR description indicates this was intentional. The changes in fork.sh, gptme.toml, and knowledge/forking-workspace.md reflect this removal.
3. knowledge/forking-workspace.md:12
  • Draft comment:
    The update from CURRENT_TASK.md to TOOLS.md is consistent with the PR's goal to eliminate CURRENT_TASK.md. Ensure that all references to CURRENT_TASK.md are removed throughout the codebase.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The removal of CURRENT_TASK.md is consistent across the files, and the PR description indicates this was intentional. The changes in fork.sh, gptme.toml, and knowledge/forking-workspace.md reflect this removal.

Workflow ID: wflow_ymxvlfWhtWFi7w1f


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@ErikBjare ErikBjare merged commit 1ee59a9 into master Dec 20, 2024
@ErikBjare ErikBjare deleted the dev/upstream-from-bob branch December 20, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of tasks/all/, just put tasks in tasks/ Get rid of CURRENT_TASK.md?
1 participant