Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply fixes from StyleCI #28

Closed
wants to merge 1 commit into from
Closed

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Aug 23, 2021

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #28 (904bcb5) into master (342c31e) will decrease coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   57.44%   57.18%   -0.27%     
==========================================
  Files          45       45              
  Lines        1128     1128              
==========================================
- Hits          648      645       -3     
- Misses        480      483       +3     
Impacted Files Coverage Δ
src/BaseIntervalPoint.php 83.33% <ø> (ø)
src/Date/DateInterval.php 48.68% <ø> (ø)
src/Date/DateIntervalPoint.php 100.00% <ø> (ø)
src/DateTime/DateTimeInterval.php 48.68% <ø> (ø)
src/DateTime/DateTimeIntervalPoint.php 100.00% <ø> (ø)
src/Exception/OutOfIntervalException.php 0.00% <ø> (ø)
src/IPv4/IPv4Interval.php 42.02% <ø> (-1.45%) ⬇️
src/IPv4Network/IPv4Network.php 88.63% <ø> (ø)
src/IPv4Network/IPv4NetworkComparator.php 55.55% <ø> (ø)
src/IPv6/IPv6Interval.php 50.00% <ø> (-1.62%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 342c31e...904bcb5. Read the comment docs.

@peter-gribanov peter-gribanov self-assigned this Aug 23, 2021
@peter-gribanov peter-gribanov added this to the Release v0.2.3 milestone Aug 23, 2021
@simPod simPod closed this Aug 23, 2021
@simPod simPod deleted the analysis-RvGGOj branch August 23, 2021 09:34
@peter-gribanov
Copy link
Member

peter-gribanov commented Aug 23, 2021

Please reopen this PR. The PR closes itself due to an error in Style CI.
I discard Style CI where possible and replace it with PHP-CS-Fixer.

@simPod
Copy link
Contributor Author

simPod commented Aug 23, 2021

Yea I see. Cannot reopen. -> #29

I have experience only with phpcs, don't use php-cs-fixer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants