fix: Handle 404s for deactivated users when exporting exposures #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kochalex
commented
Apr 19, 2022
kochalex
commented
Apr 19, 2022
gouline
reviewed
Apr 20, 2022
kochalex
commented
Apr 20, 2022
|
Updated the error handling - I'm also happy to add a new card to the mocked responses to test the 404 per your other comment if you would like. |
|
I'm good with this pending the additional test mock plus making CI pass. |
|
@kochalex Still planning to get this merged? |
gouline
changed the title
gouline
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where exporting exposures crashes
dbt-metabasewhen the owner of a card is a deactivated user. The metabase API has a check if a user is deactivated when running a GET to/api/user/:idand returns a 404.Fixes: #88