feat: Add flag to skip syncing sources, and allow meta-defined display names #95
Conversation
…s with spaces since metabase throws them away
There was a problem hiding this comment.
Run CI checks locally and fix any failures before pushing, GitHub waits for me to run them in Actions for first-time contributors.
@z3z1ma Do you remember what source models are used for after reading, apart from being exported to Metabase? If they are not exported, is there any point in reading them in the first place? Trying to think whether they should be excluded from the Metabase client (how this PR implements it) or from being read in the parsers.
Ah I'm sorry! To be honest I didn't notice them until I got the failure email, but will do that. Re: formatting, I don't see a |
|
black is in @gouline I think it might be cleaner/more logical to exclude in the parser with a flag and only pass that flag from the |
No regular work is done on this repository so nobody will be updating those pinned versions, use latest. Create a virtual env if it conflicts with other projects. |
|
@atvaccaro Still planning to get this merged? |
gouline
changed the title
gouline
force-pushed
the
feat/exclude-sources
branch
from
647e5cd to
7d9fbbf
Compare
* feat: Add flag to skip syncing sources, and allow meta-defined display names (#95) * handle display names defined in meta, and replace description newlines with spaces since metabase throws them away * allow flag to toggle metabase sources sync; default is to skip * Fixes for code review and CI errors * Parser test for model display name Co-authored-by: Andrew Vaccaro <[email protected]>
* Raise style fix * feat: Allow excluding dbt sources when exporting to Metabase (#109) * feat: Add flag to skip syncing sources, and allow meta-defined display names (#95) * handle display names defined in meta, and replace description newlines with spaces since metabase throws them away * allow flag to toggle metabase sources sync; default is to skip * Fixes for code review and CI errors * Parser test for model display name Co-authored-by: Andrew Vaccaro <[email protected]> * fix: circular foreign key reference (#110) * fix: circular foreign key reference (#106) Co-authored-by: Mike Gouline <[email protected]> * Fmt * Nicer Python Co-authored-by: Joël Luijmes <[email protected]> * Add display_name for columns * Quote fix * Add to test Co-authored-by: Mike Gouline <[email protected]> Co-authored-by: Andrew Vaccaro <[email protected]> Co-authored-by: Joël Luijmes <[email protected]>
* Add `display_name` option for field names (#111) * Raise style fix * feat: Allow excluding dbt sources when exporting to Metabase (#109) * feat: Add flag to skip syncing sources, and allow meta-defined display names (#95) * handle display names defined in meta, and replace description newlines with spaces since metabase throws them away * allow flag to toggle metabase sources sync; default is to skip * Fixes for code review and CI errors * Parser test for model display name Co-authored-by: Andrew Vaccaro <[email protected]> * fix: circular foreign key reference (#110) * fix: circular foreign key reference (#106) Co-authored-by: Mike Gouline <[email protected]> * Fmt * Nicer Python Co-authored-by: Joël Luijmes <[email protected]> * Add display_name for columns * Quote fix * Add to test Co-authored-by: Mike Gouline <[email protected]> Co-authored-by: Andrew Vaccaro <[email protected]> Co-authored-by: Joël Luijmes <[email protected]> * Display name implementation and tests Co-authored-by: Jack Cook <[email protected]> Co-authored-by: Andrew Vaccaro <[email protected]> Co-authored-by: Joël Luijmes <[email protected]>
Hey I'm so sorry and thank you for getting this through. I've been heads-down on a major project and refactor and never got back to this. |
This tool is amazing!
I have a couple features that may be helpful.
First, adding a flag to skip all dbt sources. In our project, we ultimately use Metabase on top of BigQuery, but we don't import source datasets into Metabase. Without the flag,
dbt-metabasethrows errors as it tries to sync dbt source models.Second, adding
metabase.display_nameas an optional field. We deal with a lot of GTFS data, so our model names naturally have GTFS as a common acronym. Currently it gets title-cased asGtfsin many situations, which is annoying. So I wanted to have the ability to override the Metabasedisplay_nameproperty.