feat: Support --metabase_session_id #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metabase lacks proper support for authenticating from automation, which means we have to exchange a username and password for a session token before each invocation of this command. These count as login attempts, which are rate limited. Depending on your needs, you may hit the rate limit and find your schemas can no longer be synced. Providing a --metabase_session_id allows the user to reuse and existing Metabase session, should they have it, allowing them to avoid the login rate limits (and in some cases, an annoying email!).
|
Hey team! I haven't written any Python in years so this is unlikely to work, but I'd love early feedback on the proposed change. I'll make sure this is actually functional once it gets the green light. |
|
Approach looks fine overall, you have some syntax errors as the CI shows. Please run these checks locally to debug and let me know when you're ready for a code review. |
|
Yep, I definitely eye balled this! Now I know you're ok with the approach I'll fix it up on Monday :) |
|
@lawrencejones Still planning to get this merged? |
gouline
changed the title
gouline
added a commit
that referenced
this pull request
Jul 6, 2022
* Support --metabase_session_id (#83) Metabase lacks proper support for authenticating from automation, which means we have to exchange a username and password for a session token before each invocation of this command. These count as login attempts, which are rate limited. Depending on your needs, you may hit the rate limit and find your schemas can no longer be synced. Providing a --metabase_session_id allows the user to reuse and existing Metabase session, should they have it, allowing them to avoid the login rate limits (and in some cases, an annoying email!). Co-authored-by: Mike Gouline <[email protected]> * Fix CI errors Co-authored-by: Lawrence Jones <[email protected]>
|
Ah sorry about this, haven't had a chance to get back to our data stuff since I was first working on it. Appreciate you getting this over the line 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metabase lacks proper support for authenticating from automation, which
means we have to exchange a username and password for a session token
before each invocation of this command.
These count as login attempts, which are rate limited. Depending on your
needs, you may hit the rate limit and find your schemas can no longer be
synced.
Providing a --metabase_session_id allows the user to reuse and existing
Metabase session, should they have it, allowing them to avoid the login
rate limits (and in some cases, an annoying email!).