feat: allow self reference #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gouline
reviewed
Jul 7, 2022
I swear I ran black manually, but then didn't commit the changes... 🙈
Yes this PR properly fixes #74. That is why I had to remove the set logic 🙂 |
Excellent, adding a resolve hook to the description 🎉 |
gouline
reviewed
Jul 8, 2022
gouline
approved these changes
Jul 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New approach of #110. This logic now allows the self reference / circular reference.
I made this logic based on my initial work (i.e., before refactor of @gouline). By removing the set, it's now possible to have a self reference. In addition, as some assumptions are made I added some warning logger if in future dbt manifest changes.
Resolves #74