Improve BottomSheet behavior for dynamic content and animation states #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enhances the BottomSheet component to better handle dynamic content changes and animation states. Key changes include: - Added logic to manage the initial mount and dynamic content changes. - Improved handling of closed states and snap point changes. - Ensured that the closest snap point is returned when necessary. - Refined the conditions under which the flag is set. **Risks:** - Potential regressions in existing animation behavior if not thoroughly tested. - Changes may introduce unexpected behavior in edge cases related to snap points. **Benefits:** - Improved user experience with more responsive and accurate positioning of the BottomSheet. - Enhanced maintainability and clarity of the code regarding animation states.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enhances the BottomSheet component to better handle dynamic content changes and animation states. Key changes include:
Risks:
Benefits:
Please provide enough information so that others can review your pull request:
Motivation
Fix Bottom Sheet Content Height Issues
Overview
This PR fixes an issue where the bottom sheet would unexpectedly close when its content height changes. The current implementation incorrectly handles snap point changes during content updates, causing the sheet to close instead of maintaining its position.
Key Problems Addressed
Solution
The patch improves position evaluation logic and adds proper state management to ensure the bottom sheet maintains expected behavior during content updates while preserving intended open/close functionality.
Additional Changes