fix: check if next and current indices are different before animating to a snap position #1095
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1094
Motivation
On Android the bottomsheet was getting stuck to the height of keyboard when a user would open and close the keyboard really quickly. It was because of the following lines:
react-native-bottom-sheet/src/components/bottomSheet/BottomSheet.tsx
Lines 1318 to 1323 in cebae97
while doing the check if animation state is running and snapping to that point, it also has to make sure current and next indices are not equal since in that case the user did not try to snap to any point.
Using the following example:
Before:
Screenrecorder-2022-09-09-19-29-22-33.mp4
After:
Screenrecorder-2022-09-09-19-29-42-302.mp4