Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added item space props #11

Merged
merged 8 commits into from
Apr 14, 2020
Merged

feat: added item space props #11

merged 8 commits into from
Apr 14, 2020

Conversation

gorhom
Copy link
Owner

@gorhom gorhom commented Apr 13, 2020

with this pr, user can control tab bar item spaces

<AnimatedTabBar
  itemInnerSpace={{ horizontal: 6, vertical: 6 }}
  itemOuterSpace={{ horizontal: 6, vertical: 6 }}
  tabs={tabs}
  item {...props} />

jesster2k10 and others added 8 commits April 10, 2020 11:53
@jesster2k10
fix: ensure styles can be overridden
16e6010 
The previous setup meant that if you were to provide your own `paddingBottom` to the style object on the `tabBarOptions`, it would not override the default value. For some people, the size of the tab bar initially may be too large to suit there UI so having the ability to override this is quite important.
@jesster2k10
feat: add support to customise the bar item styles
f004439
@jesster2k10
feat: add support to customise the bar item styles
dae3dce
@gorhom
Merge pull request #9 from jesster2k10/master
5716135 
Support to tweak the size of the tab bar
@gorhom
chore: add configurable iterm spaces props
e784338
@gorhom
chore: updated tabbar props to pick props from BottomTabBarProps
72f5de6
@gorhom
docs: updated readme file to include the new props
0121c03
@gorhom
docs: updated readme file to include the new props
c9b9cee
@gorhom
Copy link
Owner Author

gorhom commented Apr 13, 2020

@jesster2k10 , would you mind testing it :)

@gorhom gorhom linked an issue Apr 13, 2020 that may be closed by this pull request
Tab bar pushes too close to the edges of the screen on small devices #10
Closed
@jesster2k10
Copy link
Contributor

@jesster2k10 , would you mind testing it :)

No problem, I’ll do it within the next hour or so

@gorhom gorhom merged commit ae1f7e8 into master Apr 14, 2020
@gorhom gorhom deleted the feature/item-size branch April 14, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tab bar pushes too close to the edges of the screen on small devices
2 participants
@gorhom @jesster2k10