-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Popup user interface refreshed while on same page #1389
Comments
What does "useless" mean exactly here? Please describe the specific behavior, "useless" is vague. |
@gorhill |
This makes no sense, |
The filter |
@gorhill If I only want to block flugubluc.com on gaytube.com then (as part of this test suite)? |
Now, you will have to substantiate your claim that the filter is rendered useless by some injected script -- this makes no sense. I won't try to pull information from you anymore, it's time-consuming. Be proactive: investigate and provide evidence for your claim. I will re-open if you do so. |
Both selipuquoe.com and flugubluc.com are third-party domains. |
Look in the logger to see which whitelist rules are actually applied: I can tell that the filter you just posted is not a whitelist rule, and neither is the filter you first posted, although that one didn't explicitly block those domains either. |
@lewisje @IdkWhatToPutHere Can you reproduce this #1389 (comment) ? |
@IdkWhatToPutHere Why would EasyList white list flugubluc.com only when |
@IdkWhatToPutHere Turn off |
Look at the second screenshot. |
@IdkWhatToPutHere I just noticed. We get different results. |
Post a screenshot like mine. |
@gorhill @IdkWhatToPutHere As you can see flugubluc.com shows in uBOs popup windows with default settings but not when I disable Contents from `http://www.gaytube.com/?gtdoi` in the logger 16:34:39 font http://static.images-gaytube.com/fonts/opensans/v10/cJZKeOuBrn4kERxqtaUH3T8E0i7KZn-EPnyo3HZu7kw.woff 16:34:38 script http://ss.phncdn.com/networkbar-3.2.2.js 16:34:38 script http://static.images-gaytube.com/js/categories.js?v=v20 16:34:38 script http://static.images-gaytube.com/js/dist/main.min.js?v=v20 16:34:38 css http://static.images-gaytube.com/css/dist/main.min.css?v=v20 16:34:38 inline-script http://www.gaytube.com/ 16:34:36 doc http://www.gaytube.com/ |
In the uBlock Origin popup menu, click the icon just to the right of the eyedropper; that's the logger. Then take a screenshot of the logger just like @IdkWhatToPutHere did. |
The script is loaded both times. Isn't that the opposite of what you said? |
@IdkWhatToPutHere Yes, I assumed that the popup window shold work as expected but it didn't. @lewisje @gorhill notice the red mark in the popup window on the screenshot. |
What we want to see is what precisely is whitelisting the domain. |
It's EasyList. The actual problem here is that the popup user interface isn't displaying the domain. @gorhill will have to evaluate if this needs to be fixed or not. |
@IdkWhatToPutHere Yes, and it all boils down to So that filter interfere with uBO's own popup window. |
Are you sure? Please read the first description in this post If not, should |
A filter won't help. Since the |
Your filter |
@IdkWhatToPutHere Yeah, but this issue can help fixing a bug as you said. Then I get less confused when I evaluate my filters. |
Yes, but |
@IdkWhatToPutHere Please give me a suitable title and I will change it. |
Maybe |
Was the URL of the tab changed to In my fiddling with the |
No. Also, did you read #1389 (comment) ? |
There is a quirk specific to Firefox here. Unclear whether this is fixable. So far my understanding is that uBO receives a "Location Change" event after it has started to process the document. A "Location Change" event will cause all the data collated from the page to be reset (as occur when a page is force-reloaded), and so the record that there was a network request to "Location Change" events are always received before the network request to fetch the document is processed. For some reasons it does not seem to happen here. Using synchronous messaging from in |
I think it is best to ask Firefox developers: Also, EasyList have been requested to block flugubluc.com. If you do not know how to reproduce this issue then please make use of it before gaytube might stop using flugubluc.com. |
@flyingzebras why you want to block |
@smed79 Both of them are ad domains. |
@flyingzebras No ads from these domains ! all domains http://pastebin.com/raw/sJ9aaCX9 Try these filters on
|
@smed79 The main focus here is to fix the bug that is triggered by flugubluc.com. Thank you for letting me know that selipuquoe.com is used for ad blocking detection though. |
I noticed that these filters are incompatible, they hide flugubluc.com in uBO's own popup window:
The prior filter is found in
uBlock filters
and have a tendency to make the latter filter useless.Why do they interfere?
The text was updated successfully, but these errors were encountered: