this fixes #344

gorhill · Jun 18, 2014 · 48737a8 · 48737a8
1 parent 65142db
commit 48737a8
Show file tree

Hide file tree

Showing 3 changed files with 40 additions and 14 deletions.
diff --git a/js/storage.js b/js/storage.js
@@ -61,6 +61,9 @@ HTTPSB.loadUserSettings = function() {
         delete store.subframeFgColor;
 
         HTTPSB.userSettings = store;
+
+        // https://github.com/gorhill/httpswitchboard/issues/344
+        HTTPSB.userAgentSpoofer.shuffle();
     };
 
     chrome.storage.local.get(this.userSettings, settingsLoaded);

diff --git a/js/useragent.js b/js/useragent.js
@@ -21,7 +21,7 @@
 
 /******************************************************************************/
 
-(function() {
+HTTPSB.userAgentSpoofer = (function() {
 
 /******************************************************************************/
 
@@ -60,6 +60,7 @@ var userAgentSpoofer = function() {
     }
 };
 
+// Prime spoofer
 userAgentSpoofer();
 
 /******************************************************************************/
@@ -68,6 +69,10 @@ HTTPSB.asyncJobs.add('userAgentSwitcher', null, userAgentSpoofer, 120 * 1000, tr
 
 /******************************************************************************/
 
+return {
+    shuffle: userAgentSpoofer
+};
+
 })();
 
 /******************************************************************************/

diff --git a/js/usersettings.js b/js/usersettings.js
@@ -37,22 +37,40 @@ function changeUserSettings(name, value) {
         return httpsb.userSettings[name];
     }
 
+    // Pre-change
     switch ( name ) {
-        // Need to visit each pageStats object to resize ring buffer
-        case 'maxLoggedRequests':
-            value = Math.max(Math.min(value, 500), 0); 
-            httpsb.userSettings[name] = value;
-            var pageStats = httpsb.pageStats;
-            for ( var pageUrl in pageStats ) {
-                if ( pageStats.hasOwnProperty(pageUrl) ) {
-                    pageStats[pageUrl].requests.resizeLogBuffer(value);
-                }
+
+    case 'maxLoggedRequests':
+        value = Math.max(Math.min(value, 500), 0); 
+        break;
+
+    default:        
+        break;
+    }
+
+    // Change
+    httpsb.userSettings[name] = value;
+
+    // Post-change
+    switch ( name ) {
+
+    // Need to visit each pageStats object to resize ring buffer
+    case 'maxLoggedRequests':
+        var pageStats = httpsb.pageStats;
+        for ( var pageUrl in pageStats ) {
+            if ( pageStats.hasOwnProperty(pageUrl) ) {
+                pageStats[pageUrl].requests.resizeLogBuffer(value);
             }
-            break;
+        }
+        break;
+
+    // https://github.com/gorhill/httpswitchboard/issues/344
+    case 'spoofUserAgentWith':
+        HTTPSB.userAgentSpoofer.shuffle();
+        break;
 
-        default:        
-            httpsb.userSettings[name] = value;
-            break;
+    default:        
+        break;
     }
 
     httpsb.saveUserSettings();