Skip to content
This repository was archived by the owner on Jan 11, 2019. It is now read-only.

doesnt work in parallel usage (multiple goroutines) #26

Closed
rhaps107 opened this issue Apr 19, 2017 · 3 comments
Closed

doesnt work in parallel usage (multiple goroutines) #26

rhaps107 opened this issue Apr 19, 2017 · 3 comments

Comments

@rhaps107
Copy link

In parsing, global package variable layoutRegexp is changing. It is map, so usage in multiple gorountines causes map concurrent write error.
@gorhill
Copy link
Owner

gorhill commented Apr 19, 2017

Is there a written rule out there that all packages must be concurrency-safe?

@s7v7nislands
Copy link

so when using this package, I can't using goroutine?

@hus787
Copy link

hus787 commented Jun 6, 2017

@gorhill I suppose so else Golang doesn't guarantee anything.

Ref: golang/go#13446 (comment)

kyoh86 pushed a commit to wacul/batch that referenced this issue Aug 2, 2017
@yamada-wacul
Support parallel usage for Cron.
2c3cddb 
This commit is the patch for gorhill/cronexpr#26.
@kyoh86 kyoh86 mentioned this issue Aug 2, 2017
Merged
dadgar added a commit to dadgar/cronexpr that referenced this issue Sep 15, 2017
@dadgar
Allow library to be used in parallel
675cac9 
This PR allows concurrent calls to Parse. Further it makes the test be
part of the same package.

Fixes gorhill#26
@dadgar dadgar mentioned this issue Sep 15, 2017
Merged
@nefeg nefeg mentioned this issue Jan 11, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@s7v7nislands @gorhill @hus787 @rhaps107