-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WebAssembly support (GOARCH=wasm). #25
Comments
I have something functional but not elegant available for those interested here: I'm not really interested in covering this off properly as I will most likely move away from Websocket in the future. |
Thanks for opening the issue, and for sending a draft PR! I tested it with one of my projects that uses WebSockets just now, and I can see that it compiles and functions partially, but after some amount of bytes (or messages), there is a discrepancy in the data sent/received, causing my protocol to report an error. Still, it's helpful to have it as a reference, so thanks for providing it! |
@dmitshur Instead of adding support for WASM to this package, what are your thoughts on recommending my WebSocket package instead? The client side can target WASM directly with nearly the same API as for non WASM targets It should also work for GopherJS once GopherJS supports Go 1.13. This would also resolve #29 and every other issue/PR on this library. |
This package should be updated to use the following library so that websocket usage can target wasm and gopherjs:
"github.com/gopherjs/gopherwasm/js"
This will require wrapping callbacks with
js.NewEventCallback()
(and calling .Release()) and changing *js.Object to js.ValueThe text was updated successfully, but these errors were encountered: