[FEATURE] Ask for setup if not initialized #2975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2963. Tested-by: Eng Zer Jun <[email protected]> Signed-off-by: Eng Zer Jun <[email protected]>
AnomalRoil
previously approved these changes
Oct 20, 2024
dominikschulz
requested changes
Oct 20, 2024
internal/action/init.go
Outdated
| @@ -55,6 +55,15 @@ func (s *Action) IsInitialized(c *cli.Context) error { | |||
| out.Printf(ctx, logo) | |||
| out.Printf(ctx, "🌟 Welcome to gopass!") | |||
| out.Noticef(ctx, "No existing configuration found.") | |||
|
|
|||
| contSetup, err := termio.AskForBool(ctx, "❓ Do you want to continue to setup?", true) | |||
There was a problem hiding this comment.
The third parameter to AskForBool is the default. I think that should be false in this case.
If gopass is run non-interactively it will always use the default value and we only want to start the setup flow if the user explicitly asks for it. So please change true to false and then we should be good.
Reference: #2975 (comment) Signed-off-by: Eng Zer Jun <[email protected]>
dominikschulz
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2963.
Before
before.mp4
After
after.mp4