[DEPRECATION] Remove references to deprecated rand.Seed #2953
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Note: reopened this PR after creating and squashing
gofumpt
commit)Remove references to deprecated rand.Seed (#2650).
Context:
math/rand.Seed
is deprecated, andmath/rand
is already seeded by default.math/rand.Seed
will be a no-op, breaking the testTestPwgenNoCrand
.See method documentation in the link above for further info.
Code Changes:
Rand
variable, so that its value can be injected in tests;TestPwgenNoCrand
toTestPwgenNoCrandFallback
, to make the expected behaviour clearer;Shred
does not need to seed, nor doesTestLoadFromEnv
in config_test,TestPwgenNoCrandFallback
must restore the randomness so thatTestLoadFromEnv
can work properly.This also removes the side-effect that fsutil's Shred was overwriting the seed set by pwgen.