Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it more obvious when we apply a rule on password generation #2140

Closed
AnomalRoil opened this issue Feb 23, 2022 · 1 comment · Fixed by #2145
Closed

Make it more obvious when we apply a rule on password generation #2140

AnomalRoil opened this issue Feb 23, 2022 · 1 comment · Fixed by #2145
Assignees
Labels
cleanup Code hygiene documentation good-first-issue Good for beginners starting to contribute Hacktoberfest ux User experience / User Interface related
Milestone

Comments

@AnomalRoil
Copy link
Member

Should we make it more obvious if we apply a canned rule?

Originally posted by @dominikschulz in #2123 (reply in thread)

The best way would probably to add an info log saying "Matched domain name with password rule [{add the rule here}].

We might also want to consider adding a flag/env var to bypass rule checking, and test how it behaves when generating a key-value instead of the main password.

@AnomalRoil AnomalRoil added cleanup Code hygiene documentation good-first-issue Good for beginners starting to contribute Hacktoberfest ux User experience / User Interface related labels Feb 23, 2022
@AnomalRoil AnomalRoil added this to the 1.x.x milestone Feb 23, 2022
@dominikschulz
Copy link
Member

So for me it works as expected:

$ gopass generate test/allianz.com.br/test 24
Using password rules for allianz.com.br ...
How long should the password be? (min: 4, max: 4) (q to abort) [4]: 
✅ Password for entry "test/allianz.com.br/test" generated
Not printing secrets by default. Use 'gopass show test/allianz.com.br/test' to display the password.

$ gopass show -o test/allianz.com.br/test | wc -c
4

@dominikschulz dominikschulz self-assigned this Feb 26, 2022
dominikschulz added a commit to dominikschulz/gopass that referenced this issue Feb 26, 2022
dominikschulz added a commit to dominikschulz/gopass that referenced this issue Feb 26, 2022
Fixes gopasspw#2140

RELEASE_NOTES=n/a

Signed-off-by: Dominik Schulz <[email protected]>
dominikschulz added a commit that referenced this issue Mar 4, 2022
Fixes #2140

RELEASE_NOTES=n/a

Signed-off-by: Dominik Schulz <[email protected]>
kpitt pushed a commit to kpitt/gopass that referenced this issue Jul 21, 2022
Fixes gopasspw#2140

RELEASE_NOTES=n/a

Signed-off-by: Dominik Schulz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code hygiene documentation good-first-issue Good for beginners starting to contribute Hacktoberfest ux User experience / User Interface related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants