Add various pixel-generation methods to GoostGeometry2D
#78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xrayez
added
enhancement
For consistency with other pixel-based methods. This also avoids potential confusion with original/correct Bresenham line algorithm, so this is mentioned in the documentation. We'd also like to avoid having API with names of the algorithms, unless absolutely necessary.
For compatibility with the `circle()` method in the same class.
Xrayez
force-pushed
the
geometry-pixelated
branch
from
0574c34 to
cfeb8ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having
bresenham_line()is nice, but proves to be difficult to use via script (have to handle rounding, potentially avoiding duplicate points etc.)Pixelated circle
Adds
pixel_circle()method.Pixelated polygon/polyline
Adds
polygon_to_pixels()andpolyline_to_pixels()methods.This PR also renames
bresenham_line()topixel_line()for consistency with added features, also see other rationale in the commit description.