Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move FleetAllocationOverflow to Beta #3515

Merged
merged 8 commits into from
Nov 21, 2023
Merged

Move FleetAllocationOverflow to Beta #3515

merged 8 commits into from
Nov 21, 2023

Conversation

Kalaiselvi84
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #3514

Special notes for your reviewer:

@Kalaiselvi84 Kalaiselvi84 marked this pull request as ready for review November 16, 2023 22:55
@google-oss-prow google-oss-prow bot requested a review from aLekSer November 16, 2023 22:56
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c31c58bf-1720-4eea-b990-60689508da38

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3515/head:pr_3515 && git checkout pr_3515
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-e1e8edb-amd64

@markmandel
Copy link
Collaborator

Looks good -

I had a search for FleetAllocationOverflow and found a few more adjustments to make:

agones/site/content/en/docs/Reference/fleet.md

Lines 46 to 47 in 065052a

# [Stage:Alpha]
# [FeatureFlag:FleetAllocationOverflow]

agones/pkg/apis/agones/v1/fleet.go

Lines 62 to 67 in 065052a

// [Stage: Alpha]
// [FeatureFlag:FleetAllocationOverflow]
// Labels and/or Annotations to apply to overflowing GameServers when the number of Allocated GameServers is more
// than the desired replicas on the underlying `GameServerSet`
// +optional
AllocationOverflow *AllocationOverflow `json:"allocationOverflow,omitempty"`

agones/pkg/apis/agones/v1/gameserverset.go

Lines 62 to 67 in 065052a

// [Stage: Alpha]
// [FeatureFlag:FleetAllocationOverflow]
// Labels and Annotations to apply to GameServers when the number of Allocated GameServers drops below
// the desired replicas on the underlying `GameServerSet`
// +optional
AllocationOverflow *AllocationOverflow `json:"allocationOverflow,omitempty"`

agones/examples/fleet.yaml

Lines 53 to 63 in 065052a

# [Stage:Alpha]
# [FeatureFlag:FleetAllocationOverflow]
# Labels and/or Annotations to apply to overflowing GameServers when the number of Allocated GameServers exceeds
# the desired replicas in the underlying `GameServerSet`
# Commented out since Alpha, and disabled by default
# allocationOverflow:
# labels:
# mykey: myvalue
# version: "" # empty an existing label value
# annotations:
# otherkey: setthisvalue

(This one can be uncommented)

If you could also do a search to triple check please, make sure I didn't miss anything else - that would be apprecaited!

@google-oss-prow google-oss-prow bot added size/XXL and removed size/S labels Nov 18, 2023
@Kalaiselvi84
Copy link
Contributor Author

(This one can be uncommented)

If you could also do a search to triple check please, make sure I didn't miss anything else - that would be apprecaited!

Completed the updates on the specified files, the .md files are now wrapped with the feature shortcodes, and ran make gen-api-docs command to update agones_crd_api_reference.html file.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 5afde00f-c718-4770-889c-ae71cb68de35

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel
markmandel reviewed Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just found a very small nit, and then good to merge.

examples/fleet.yaml Outdated
# version: "" # empty an existing label value
# annotations:
# otherkey: setthisvalue
# Now in Beta, and can be enabled
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Now in Beta, and can be enabled
# Now in Beta, and enabled by default

@markmandel
Copy link
Collaborator

Cascading failure on an autopilot cluster - very odd.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0b587f2f-cc55-4e6f-8563-9f5bbd9fa8a7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3515/head:pr_3515 && git checkout pr_3515
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-4db9aec-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 83584b78-cacd-401a-9602-74f8b4a59aa7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3515/head:pr_3515 && git checkout pr_3515
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-2e317bd-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 6b9ecc25-67c0-469c-99f0-51dc51a44a9b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3515/head:pr_3515 && git checkout pr_3515
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-2078dc8-amd64

@google-oss-prow google-oss-prow bot added the lgtm label Nov 21, 2023
@markmandel markmandel merged commit ddadfe7 into googleforgames:main Nov 21, 2023
2 checks passed
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kalaiselvi84, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Kalaiselvi84 Kalaiselvi84 added kind/feature New features for Agones and removed kind/other labels Dec 12, 2023
@Kalaiselvi84 Kalaiselvi84 deleted the fleetAllocationOverflow branch March 15, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@aLekSer aLekSer Awaiting requested review from aLekSer

Assignees

@markmandel markmandel

Labels
approved kind/feature New features for Agones lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move FleetAllocationOverflow to Beta
3 participants
@Kalaiselvi84 @agones-bot @markmandel