Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ruby-jwt 2.0 #93

Merged
merged 2 commits into from
Oct 4, 2017
Merged

Support ruby-jwt 2.0 #93

merged 2 commits into from
Oct 4, 2017

Conversation

jurriaan
Copy link
Contributor

This version of ruby-jwt requires specification of the algorithm (see
jwt/ruby-jwt#184) for more information.

jurriaan added a commit to jurriaan/google-auth-library-ruby that referenced this pull request Sep 15, 2017
This version of ruby-jwt requires specification of the algorithm (see
jwt/ruby-jwt#184) for more information.

I've created a PR on signet to. That has to be merged before ruby-jwt
2.0 can be really used (see googleapis/signet#93).

Tested locally against ruby-jwt 2.0 and 1.5.6.
jurriaan added a commit to jurriaan/google-auth-library-ruby that referenced this pull request Sep 15, 2017
This version of ruby-jwt requires specification of the algorithm (see
jwt/ruby-jwt#184) for more information.

I've created a PR on signet to. That has to be merged before ruby-jwt
2.0 can be really used (see googleapis/signet#93).

Tested locally against ruby-jwt 2.0 and 1.5.6.
jurriaan added a commit to jurriaan/google-auth-library-ruby that referenced this pull request Sep 15, 2017
This version of ruby-jwt requires specification of the algorithm (see
jwt/ruby-jwt#184) for more information.

I've created a PR on signet to. That has to be merged before ruby-jwt
2.0 can be really used (see googleapis/signet#93).

Tested locally against ruby-jwt 2.0 and 1.5.6.
This version of ruby-jwt requires specification of the algorithm (see
jwt/ruby-jwt#184) for more information.
@jurriaan
Copy link
Contributor Author

@sqrrrl googleapis/google-auth-library-ruby#119 has just been merged. For google-auth-library-ruby to depend on jwt 2.0 this PR needs to be merged. It was failing on CI due to issues with JRuby so I pushed a fix for that too.

@jurriaan
Copy link
Contributor Author

@hxiong388 https://github.com/google/google-auth-library-ruby depends on this library, can you make sure this gets merged somehow, so that it is possible to use ruby-jwt 2.0 with google-auth-library-ruby

@hxiong388
Copy link

@jurriaan Thanks for bringing this to my attention. I don't have collaborator privilege to this repo. We'll work something out internally.

@dazuma dazuma self-requested a review October 3, 2017 23:43
@dazuma dazuma merged commit c9d21b3 into googleapis:master Oct 4, 2017
@jurriaan jurriaan deleted the jwt-2-0-support branch October 5, 2017 08:21
@koenrh
Copy link

koenrh commented Oct 7, 2017

@dazuma Could you release a new version so we can use version 2 of the 'jwt' gem in libraries that are dependent on 'signet'? Thanks.

@dazuma
Copy link
Member

dazuma commented Oct 9, 2017

@koenrh I'm working on testing and coordinating releases with the other related libraries such as googleauth. We'll have a release in the next few days.

@mvastola mvastola mentioned this pull request Oct 12, 2017
oleksandrbyk added a commit to oleksandrbyk/olek-google-auth-library that referenced this pull request Mar 4, 2019
This version of ruby-jwt requires specification of the algorithm (see
jwt/ruby-jwt#184) for more information.

I've created a PR on signet to. That has to be merged before ruby-jwt
2.0 can be really used (see googleapis/signet#93).

Tested locally against ruby-jwt 2.0 and 1.5.6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants