-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ruby-jwt 2.0 #93
Conversation
This version of ruby-jwt requires specification of the algorithm (see jwt/ruby-jwt#184) for more information. I've created a PR on signet to. That has to be merged before ruby-jwt 2.0 can be really used (see googleapis/signet#93). Tested locally against ruby-jwt 2.0 and 1.5.6.
This version of ruby-jwt requires specification of the algorithm (see jwt/ruby-jwt#184) for more information. I've created a PR on signet to. That has to be merged before ruby-jwt 2.0 can be really used (see googleapis/signet#93). Tested locally against ruby-jwt 2.0 and 1.5.6.
This version of ruby-jwt requires specification of the algorithm (see jwt/ruby-jwt#184) for more information. I've created a PR on signet to. That has to be merged before ruby-jwt 2.0 can be really used (see googleapis/signet#93). Tested locally against ruby-jwt 2.0 and 1.5.6.
This version of ruby-jwt requires specification of the algorithm (see jwt/ruby-jwt#184) for more information.
44f7951
to
3cca830
Compare
@sqrrrl googleapis/google-auth-library-ruby#119 has just been merged. For google-auth-library-ruby to depend on jwt 2.0 this PR needs to be merged. It was failing on CI due to issues with JRuby so I pushed a fix for that too. |
@hxiong388 https://github.com/google/google-auth-library-ruby depends on this library, can you make sure this gets merged somehow, so that it is possible to use ruby-jwt 2.0 with google-auth-library-ruby |
@jurriaan Thanks for bringing this to my attention. I don't have collaborator privilege to this repo. We'll work something out internally. |
@dazuma Could you release a new version so we can use version 2 of the 'jwt' gem in libraries that are dependent on 'signet'? Thanks. |
@koenrh I'm working on testing and coordinating releases with the other related libraries such as googleauth. We'll have a release in the next few days. |
This version of ruby-jwt requires specification of the algorithm (see jwt/ruby-jwt#184) for more information. I've created a PR on signet to. That has to be merged before ruby-jwt 2.0 can be really used (see googleapis/signet#93). Tested locally against ruby-jwt 2.0 and 1.5.6.
This version of ruby-jwt requires specification of the algorithm (see
jwt/ruby-jwt#184) for more information.