chore: exclude prediction.proto
#2775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
JoeWang1127
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
diegomarquezp
approved these changes
May 15, 2024
blakeli0
reviewed
May 15, 2024
| "google/cloud/visionai/v1"*) | ||
| # this proto is excluded in //google/cloud/visionai/v1:google-cloud-visionai-v1-java | ||
| # we can remove this exclusion after cl/631529749 is submitted. | ||
| removed_proto="google/cloud/visionai/v1/prediction.proto" |
There was a problem hiding this comment.
If this proto is removed from googleapis, is this logic going to no-op or error out?
There was a problem hiding this comment.
I tested the command in cloudtop and it doesn't error
(.venv) [hi on] joewa@joewa-linxu:~/workspace/sdk-platform-java$ removed=google/cloud/visionai/prediction.proto
(.venv) [hi on] joewa@joewa-linxu:~/workspace/sdk-platform-java$ proto_files="google/example/example.proto google/example/another_example.proto"
(.venv) [hi on] joewa@joewa-linxu:~/workspace/sdk-platform-java$ mod="${proto_files//${removed}/}"
(.venv) [hi on] joewa@joewa-linxu:~/workspace/sdk-platform-java$ echo $?
0
(.venv) [hi on] joewa@joewa-linxu:~/workspace/sdk-platform-java$ echo $mod
google/example/example.proto google/example/another_example.proto
lqiu96
pushed a commit
that referenced
this pull request
May 16, 2024
In this PR: - Exclude `google/cloud/visionai/v1/prediction.proto` until cl/631529749 is submitted Test generated client in googleapis/google-cloud-java#10845.
lqiu96
pushed a commit
that referenced
this pull request
May 22, 2024
In this PR: - Exclude `google/cloud/visionai/v1/prediction.proto` until cl/631529749 is submitted Test generated client in googleapis/google-cloud-java#10845.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
google/cloud/visionai/v1/prediction.protountil cl/631529749 is submittedTest generated client in googleapis/google-cloud-java#10845.