Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bumping grpc to 1.54.0 #1570

Merged
merged 1 commit into from
Mar 28, 2023
Merged

chore: bumping grpc to 1.54.0 #1570

merged 1 commit into from
Mar 28, 2023

Conversation

ddixit14
Copy link
Contributor

@ddixit14 ddixit14 commented Mar 28, 2023 •
edited
Loading

(Will close #1560 once this is merged in)

@ddixit14 ddixit14 requested a review from a team as a code owner March 28, 2023 16:00
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Mar 28, 2023
@sonarqubecloud
Copy link

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[java_showcase_integration_tests] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[java_showcase_unit_tests] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@suztomo
Copy link
Member

suztomo commented Mar 28, 2023

SonarCloud is failing:

Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)

This is fine because showcase is generated code.

@ddixit14 ddixit14 merged commit a93d63b into main Mar 28, 2023
@ddixit14 ddixit14 deleted the grpc-1.54.0 branch March 28, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burkedavison burkedavison burkedavison left review comments

@suztomo suztomo suztomo approved these changes

Assignees
No one assigned
Labels
size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ddixit14 @suztomo @burkedavison