Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add SuperObjectValue and unit test #145

Closed
wants to merge 9 commits into from
Closed

feat: Add SuperObjectValue and unit test #145

wants to merge 9 commits into from

Conversation

summer-ji-eng
Copy link
Contributor

fullfill super

  • access parent class's fields
  • access parent class's method

@summer-ji-eng summer-ji-eng changed the title Add SuperObjectValue and unit test feat: Add SuperObjectValue and unit test Jul 29, 2020
miraleung added 2 commits July 30, 2020 11:26
@miraleung
fix: clean up composer methods (#138)
bb29ab3
@miraleung
[ggj] feat: add starter for ServiceClientTest generation (#139)
f4dab91 
* feat: support templated method definitions

* fix!: MethodInvocationExpr: use TypeNode instead of names for static references

* feat: mix IdNode and TypeNode in template vars for methods

* feat: generate GrpcServiceCallableFactory class

* fix: clean up composer methods

* feat: add starter for ServiceClientTest generation
miraleung
miraleung suggested changes Jul 30, 2020
View reviewed changes
src/test/java/com/google/api/generator/engine/ast/SuperObjectValueTest.java Outdated
}

@Test
public void invalidSuperObjectValue_NonReferenceType() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_nonReferenceType, same below.

@summer-ji-eng summer-ji-eng requested a review from miraleung July 31, 2020 03:37
miraleung
miraleung suggested changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@miraleung miraleung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more change needed: Can we add an ImportWriterVisitor test? super may be in a different package than the current class.

xiaozhenliu-gg5
xiaozhenliu-gg5 reviewed Aug 4, 2020
View reviewed changes
Copy link
Contributor

@xiaozhenliu-gg5 xiaozhenliu-gg5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the composer changes (ServiceClientTestClassComposer) are already checked in? If that is not intended in this PR can we checkout/merge master to isolate the superObjectValue change? Thanks

@summer-ji-eng summer-ji-eng mentioned this pull request Aug 7, 2020
Merged
@summer-ji-eng
Copy link
Contributor Author

Fix merge problem and sent new PR#159

@summer-ji-eng summer-ji-eng deleted the super_object_value branch August 7, 2020 07:20
suztomo pushed a commit that referenced this pull request Mar 21, 2023
@release-please
chore: release 1.92.5-SNAPSHOT (#145)
8a29dfa 
* updated versions.txt [ci skip]

* updated google-cloud-core-bom/pom.xml [ci skip]

* updated google-cloud-core-grpc/pom.xml [ci skip]

* updated google-cloud-core-http/pom.xml [ci skip]

* updated google-cloud-core/pom.xml [ci skip]

* updated pom.xml [ci skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaozhenliu-gg5 xiaozhenliu-gg5 xiaozhenliu-gg5 left review comments

@miraleung miraleung miraleung requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@summer-ji-eng @miraleung @xiaozhenliu-gg5