feat(auto-label): support more APIs and issue titles #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
JustinBeckwith
approved these changes
Jun 4, 2020
bcoe
approved these changes
Jun 5, 2020
There was a problem hiding this comment.
I'm supportive of this, but one thing comes to mind, it feels like it might make sense to also support the scope value in conventional commits:
feat([scope]): description
We could then move towards further adoption of the conventional commit specification, rather than inventing our own format.
I think we should support the format people are using for now mind you.
|
Thanks! These are for issue titles, which don't seem to follow conventional commits as much. Would probably need regex extraction, so I will leave that for a followup feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for some Python issues that have the API as the part before the period (for example, GoogleCloudPlatform/python-docs-samples#3923).
This also adds support for APIs that are prefixed with
cloudlikecloudiotandcloudkms.I updated the auto-detect function signature a bit to make it easier to write tests. Let me know if there is a more idiomatic way to write a table-driven style test.