fix: filter to org in payload #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
sofisl
approved these changes
Feb 21, 2020
Codecov Report
@@ Coverage Diff @@
## master #315 +/- ##
==========================================
- Coverage 85.73% 85.59% -0.15%
==========================================
Files 16 16
Lines 3225 3234 +9
Branches 320 321 +1
==========================================
+ Hits 2765 2768 +3
- Misses 445 451 +6
Partials 15 15
Continue to review full report at Codecov.
|
This was referenced Feb 25, 2020
yoshi-automation
added a commit
that referenced
this pull request
Apr 1, 2020
dbce678 commit dbce678 Author: Benjamin E. Coe <[email protected]> Date: Fri Feb 21 13:47:44 2020 -0800 fix: filter to org in payload (#315)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying problem with
automergeonGoogleCloudPlatformwas that it has a different installation ID thangoogleapis, and we weren't clever enough to support this. We now have a cron setup for bothGoogleCloudPlatformand forgoogleapis, each with a different installation ID.This was the quickest fix, we may want to revisit this design in
gcf-utilsin the future, and make it so that a single cron can have multipleinstallationIDs, this would take quite a few finicky changes though.