fix: update branch was being called too often (bonus, also loosened strictness of review check) #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
bcoe
approved these changes
Feb 20, 2020
There was a problem hiding this comment.
This looks great to me, I'm excited to get ti deployed. In the future, I'd probably have done this as two PRs, so that you can have a slightly more descriptive PR.
fix: update branch was being called too often
refactor: don't require that all reviewers have reviewed before merging
bcoe
changed the title
This was referenced Feb 25, 2020
yoshi-automation
added a commit
that referenced
this pull request
Apr 1, 2020
…trictness of review check) (#307) 5e5043f commit 5e5043f Author: sofisl <[email protected]> Date: Thu Feb 20 11:20:39 2020 -0800 fix: update branch was being called too often (bonus, also loosened strictness of review check) (#307) * fix: refactored tests, removed strictness on reviewers, loosened requirements on updating branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-addressing bug #305 and bug #304