Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Build Cop): only close duplicates when the test was run #297

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Conversation

tbpg
Copy link
Contributor

@tbpg tbpg commented Feb 19, 2020

Otherwise, if there are 50 invocations of the bot at the same time, they
will all try to close the duplicate issues. This isn't perfect, but will
be way better than 50.

Fixes #283 🦕

Otherwise, if there are 50 invocations of the bot at the same time, they
will all try to close the duplicate issues. This isn't perfect, but will
be way better than 50.
@tbpg tbpg requested a review from nnegrey February 19, 2020 17:54
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 19, 2020
@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #297 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #297      +/-   ##
==========================================
+ Coverage   87.45%   87.50%   +0.04%     
==========================================
  Files          15       15              
  Lines        2687     2696       +9     
  Branches      268      270       +2     
==========================================
+ Hits         2350     2359       +9     
  Misses        324      324              
  Partials       13       13              
Impacted Files Coverage Δ
packages/buildcop/src/buildcop.ts 94.47% <0.00%> (+0.10%) ⬆️
packages/generate-bot/main.js 74.01% <0.00%> (ø) ⬆️
packages/publish/src/publish.ts 70.83% <0.00%> (ø) ⬆️
packages/gcf-utils/src/gcf-utils.ts 77.94% <0.00%> (ø) ⬆️
packages/auto-label/src/auto-label.ts 81.57% <0.00%> (ø) ⬆️
packages/label-sync/src/label-sync.ts 80.15% <0.00%> (ø) ⬆️
packages/release-please/src/runner.ts 84.61% <0.00%> (ø) ⬆️
packages/blunderbuss/src/blunderbuss.ts 90.34% <0.00%> (ø) ⬆️
packages/failurechecker/src/failurechecker.ts 93.93% <0.00%> (ø) ⬆️
packages/merge-on-green/src/merge-on-green.ts 94.37% <0.00%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2706f4f...fdc2866. Read the comment docs.

Copy link

@nnegrey nnegrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbpg tbpg merged commit 9e953ad into master Feb 19, 2020
@tbpg tbpg deleted the buildcop branch February 19, 2020 18:09
yoshi-automation added a commit that referenced this pull request Apr 1, 2020
9e953ad
commit 9e953ad
Author: Tyler Bui-Palsulich <[email protected]>
Date:   Wed Feb 19 13:09:53 2020 -0500

    fix(Build Cop): only close duplicates when the test was run (#297)

    Otherwise, if there are 50 invocations of the bot at the same time, they
    will all try to close the duplicate issues. This isn't perfect, but will
    be way better than 50.

    Fixes #283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build Cop: duplicate issues for same test failure?
3 participants