Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Build Cop): handle issue pagination and duplicates #291

Merged
merged 1 commit into from
Feb 18, 2020
Merged

feat(Build Cop): handle issue pagination and duplicates #291

merged 1 commit into from
Feb 18, 2020

Conversation

tbpg
Copy link
Contributor

@tbpg tbpg commented Feb 18, 2020

Fixes #283.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 18, 2020
@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #291 into master will decrease coverage by 0.07%.
The diff coverage is 88.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #291      +/-   ##
==========================================
- Coverage    87.6%   87.53%   -0.08%     
==========================================
  Files          15       15              
  Lines        2622     2687      +65     
  Branches      249      266      +17     
==========================================
+ Hits         2297     2352      +55     
- Misses        312      322      +10     
  Partials       13       13
Impacted Files Coverage Δ
packages/buildcop/src/buildcop.ts 94.8% <88.09%> (-1.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dd6255...bfbc9f1. Read the comment docs.

@tbpg tbpg merged commit d70933a into master Feb 18, 2020
@tbpg tbpg deleted the buildcop branch February 18, 2020 14:21
This was referenced Feb 25, 2020
Closed
Closed
Closed
yoshi-automation added a commit that referenced this pull request Apr 1, 2020
@yoshi-automation
feat(Build Cop): handle issue pagination and duplicates (#291)
4818536 
d70933a
commit d70933a
Author: Tyler Bui-Palsulich <[email protected]>
Date:   Tue Feb 18 09:21:32 2020 -0500

    feat(Build Cop): handle issue pagination and duplicates (#291)

    Fixes #283.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@bcoe bcoe Awaiting requested review from bcoe

@sofisl sofisl Awaiting requested review from sofisl

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build Cop: duplicate issues for same test failure?
3 participants
@tbpg @JustinBeckwith @googlebot