feat: merge-on-green bot #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
chingor13
reviewed
Feb 14, 2020
chingor13
requested changes
Feb 19, 2020
Comment on lines
+44
to
48
| if (now - created > MAX_TEST_TIME) { | ||
| console.warn(`deleting stale PR ${url}`); | ||
| await handler.removePR(url); | ||
| state = 'stop'; | ||
| } |
There was a problem hiding this comment.
TODO: I'd prefer to not have a "list" method that has side effects - perhaps later refactor this to do the list, then have an explicit loop over the returned WatchPR objects that removes the expired ones.
We can probably clean this up in a follow-up PR.
There was a problem hiding this comment.
Added this as a to-do in the code!
| const branchProtectionArray = branchProtection.required_status_checks | ||
| .contexts as string[]; | ||
| const configProtectionArray = configProtection as string[]; | ||
| handler.addPR = async function addPR(wp: WatchPR, url: string) { |
There was a problem hiding this comment.
TODO: we can likely split the database functionality into its own file and import these helper functions for use in the main bot event handling.
We can clean this up in a follow-up PR.
There was a problem hiding this comment.
Also added this as well.
chingor13
requested changes
Feb 19, 2020
packages/merge-on-green/README.md
Outdated
Comment on lines
17
to
24
| Once installed, this bot merges PRs once reviews have been approved and tests have passed. Briefly speaking, the bot does the following: | ||
|
|
||
| -User kicks off a PR, adds an ‘automerge’ label | ||
| -Bot listens to PR and checks to see if appropriate label was added. If so, the PR info is added to Datastore as an entry | ||
| -** A cron job will run the logic below every four minutes, until it hits two hours. Once it hits two hours, the job will pass in a status called ‘stop’, which the logic will then use to determine an outcome ** | ||
| -Merge-on-green begins by checking if there are any reviews on the bot. If there are any non-approved reviews, assigned reviews that have not been fulfilled, or if no one has reviewed the PR, the bot will fail its check | ||
| -Merge-on-green then checks to see if there is at least one commit in the PR, if the PR has an ‘automerge’ label (i.e., if the user has removed it) | ||
| -Merge-on-green will then see what checks are required by individual languages according to the file googleapis/sloth/required-checks.json, and will map the repo to the language using the sloth.json file. If any repo has any special requirements for status checks, it should note them in the required-checks.json file |
There was a problem hiding this comment.
This markdown isn't rendering correctly
chingor13
approved these changes
Feb 19, 2020
bcoe
approved these changes
Feb 19, 2020
This was referenced Feb 25, 2020
yoshi-automation
added a commit
that referenced
this pull request
Apr 1, 2020
338cce8 commit 338cce8 Author: sofisl <[email protected]> Date: Wed Feb 19 11:42:43 2020 -0800 feat: merge-on-green bot (#287)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a feature request for a bot that automatically updates branches and merges PRs once all tests have passed and reviewers have approved.