build: codecov was finding the wrong JSON files #263
Conversation
googlebot
added
the
cla: yes
.github/workflows/ci.yml
Outdated
| @@ -42,7 +42,4 @@ jobs: | |||
| - run: npm install | |||
| - run: npm test | |||
| - run: npm i codecov | |||
There was a problem hiding this comment.
Wait a second - why do you need to install this here? Instead, should we make sure it's in our package.jsons?
There was a problem hiding this comment.
It seems like it'd be okay since it's the repo bot that's trying to run codecov, and not the individual repo package.json. I guess the place that'd be problematic is if we took the output of this process and ran other things that ended up depending on it.
There was a problem hiding this comment.
So technically, the codecov command line tool could have breaking changes from major version to major version. I don't think it's likely, but it could happen. I'd like to think we should either a.) include the dependency in package.json or b.) specify the version in the npm i call here.
If we go with b, may make sense to use npx too :)
.github/workflows/ci.yml
Outdated
| @@ -42,7 +42,4 @@ jobs: | |||
| - run: npm install | |||
| - run: npm test | |||
| - run: npm i codecov | |||
There was a problem hiding this comment.
It seems like it'd be okay since it's the repo bot that's trying to run codecov, and not the individual repo package.json. I guess the place that'd be problematic is if we took the output of this process and ran other things that ended up depending on it.
.github/workflows/ci.yml
Outdated
| @@ -42,7 +42,4 @@ jobs: | |||
| - run: npm install | |||
| - run: npm test | |||
| - run: npm i codecov | |||
There was a problem hiding this comment.
So technically, the codecov command line tool could have breaking changes from major version to major version. I don't think it's likely, but it could happen. I'd like to think we should either a.) include the dependency in package.json or b.) specify the version in the npm i call here.
If we go with b, may make sense to use npx too :)
Codecov Report
@@ Coverage Diff @@
## master #263 +/- ##
=========================================
Coverage ? 87.41%
=========================================
Files ? 15
Lines ? 2559
Branches ? 234
=========================================
Hits ? 2237
Misses ? 309
Partials ? 13Continue to review full report at Codecov.
|
| - uses: codecov/codecov-action@v1 | ||
| with: | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
| - run: ./node_modules/.bin/c8 report --reporter=text-lcov | npx codecov@3 -t ${{ secrets.CODECOV_TOKEN }} --pipe |
There was a problem hiding this comment.
I'm surprised you don't need to explicitly put the with: clause in here. But if it works, 🤷♂
There was a problem hiding this comment.
It seems like we have access to the secrets set for the repo within the action. I think with is meant more for external actions, which specify the variables they expect using inputs.
…checks (#878) * chore: first pass at github actions for some of the repo's precommit checks * build: adjust for PR comments and what was done in this other PR: googleapis/repo-automation-bots#263
9b49053 commit 9b49053 Author: Benjamin E. Coe <[email protected]> Date: Wed Feb 5 11:11:28 2020 -0800 build: codecov was finding the wrong JSON files (#263)
codecov was uploading a bunch of the wrong files, let's be more specific.